Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1271497
| From | Rob Herring <robh@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 1/2] ASoC: da7218: Add bindings documentation for DA7218 audio codec |
| Date | 2015-11-17 19:00 +0100 |
| Message-ID | <qvSHU-8dG-5@gated-at.bofh.it> (permalink) |
| References | <qtFOO-4EQ-15@gated-at.bofh.it> <qtFOO-4EQ-13@gated-at.bofh.it> <qtKbM-7AZ-25@gated-at.bofh.it> <qvSeS-81H-15@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, Nov 17, 2015 at 11:27 AM, Opensource [Adam Thomson] <Adam.Thomson.Opensource@diasemi.com> wrote: > On November 11, 2015 20:20, Rob Herring wrote: > >> > +- dlg,micbias1-lvl : Voltage (mV) for Mic Bias 1 >> > + [<1200>, <1600>, <1800>, <2000>, <2200>, <2400>, <2600>, <2800>, >> <3000>] >> > +- dlg,micbias2-lvl : Voltage (mV) for Mic Bias 2 >> > + [<1200>, <1600>, <1800>, <2000>, <2200>, <2400>, <2600>, <2800>, >> <3000>] >> >> Units please (-microvolt). > > I refer back to our previous discussion (https://lkml.org/lkml/2015/10/8/661). > This doesn't add anything and makes the binding name unnecessarily long. Why is > this being enforced? Whoever uses the binding will have to look at the > documentation to understand which values are valid anyway, so this seems like > cruft. It is simply standard, best practice for new bindings. Certainly there are examples that don't follow this, but they are either old or escaped review. Drop the 'lvl' part if you are so concerned about length. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
RE: [PATCH v2 1/2] ASoC: da7218: Add bindings documentation for DA7218 audio codec "Opensource [Adam Thomson]" <Adam.Thomson.Opensource@diasemi.com> - 2015-11-17 18:30 +0100
Re: [PATCH v2 1/2] ASoC: da7218: Add bindings documentation for DA7218 audio codec Rob Herring <robh@kernel.org> - 2015-11-17 19:00 +0100
RE: [PATCH v2 1/2] ASoC: da7218: Add bindings documentation for DA7218 audio codec "Opensource [Adam Thomson]" <Adam.Thomson.Opensource@diasemi.com> - 2015-11-18 12:40 +0100
csiph-web