Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1271275

Re: [PATCH 1/5] fs/block_dev.c: make sb_is_blkdev_sb return bool when CONFIG_BLOCK undefined

Show all headers | View raw

Yaowei Bai <baiyaowei@cmss.chinamobile.com> writes:

> Currently when CONFIG_BLOCK is defined sb_is_blkdev_sb returns bool,
> while when CONFIG_BLOCK is not defined it returns int. Let's keep
> consistent to make sb_is_blkdev_sb return bool as well when CONFIG_BLOCK
> isn't defined.
>
> No functional change.
>
> Signed-off-by: Yaowei Bai <baiyaowei@cmss.chinamobile.com>

Reviewed-by: Jeff Moyer <jmoyer@redhat.com>

> ---
>  include/linux/fs.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/fs.h b/include/linux/fs.h
> index 3aa5142..11505af 100644
> --- a/include/linux/fs.h
> +++ b/include/linux/fs.h
> @@ -2291,9 +2291,9 @@ static inline void iterate_bdevs(void (*f)(struct block_device *, void *), void
>  {
>  }
>  
> -static inline int sb_is_blkdev_sb(struct super_block *sb)
> +static inline bool sb_is_blkdev_sb(struct super_block *sb)
>  {
> -	return 0;
> +	return false;
>  }
>  #endif
>  extern int sync_filesystem(struct super_block *);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/5] fs/block_dev.c: make sb_is_blkdev_sb return bool when CONFIG_BLOCK undefined Yaowei Bai <baiyaowei@cmss.chinamobile.com> - 2015-11-17 07:50 +0100
  Re: [PATCH 1/5] fs/block_dev.c: make sb_is_blkdev_sb return bool when CONFIG_BLOCK undefined Jeff Moyer <jmoyer@redhat.com> - 2015-11-17 15:30 +0100
  [PATCH 5/5] fs/attr.c: is_sxid can be boolean Yaowei Bai <baiyaowei@cmss.chinamobile.com> - 2015-11-19 14:10 +0100
  [PATCH 4/5] fs/bad_inode.c: is_bad_inode can be boolean Yaowei Bai <baiyaowei@cmss.chinamobile.com> - 2015-11-19 14:10 +0100

csiph-web