Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1271228

Re: [PATCH 1/3] mtd: m25p80: fix module autoloading for "jedec,spi-nor" and "spi-nor"

Show all headers | View raw

Hello Brian,

On 11/16/2015 07:34 PM, Brian Norris wrote:
> Commit 43163022927b ("mtd: m25p80: allow arbitrary OF matching for
> "jedec,spi-nor"") moved the "jedec,spi-nor" handling from the
> spi_device_id table to the of_match_table, to better handle matching
> complex device tree compatible strings. With that patch, device tree
> support works as expected when m25p80.c is built into the kernel.
>
> However, that commit ignored the fact that:
> 
>  (1) (non-DT) platform devices might want to use the "spi-nor" string
>      for matching with this driver, rather than picking an arbitrary one
>      like "m25p80"
>  (2) the core SPI uevent/modalias code doesn't yet support kernel module
>      autoloading via of_match_table strings; so for DT-based devices, it
>      will only report (part of) the first compatible string used
>

Very nice changelog message!

Patch looks good to me.

Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
 
Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] mtd: m25p80: fix some module and documentation issues Brian Norris <computersforpeace@gmail.com> - 2015-11-16 23:40 +0100
  [PATCH 2/3] mtd: m25p80: replace leftover "nor-jedec" with "spi-nor" in comments Brian Norris <computersforpeace@gmail.com> - 2015-11-16 23:40 +0100
    Re: [PATCH 2/3] mtd: m25p80: replace leftover "nor-jedec" with  "spi-nor" in comments Javier Martinez Canillas <javier@osg.samsung.com> - 2015-11-17 15:00 +0100
  [PATCH 1/3] mtd: m25p80: fix module autoloading for "jedec,spi-nor" and "spi-nor" Brian Norris <computersforpeace@gmail.com> - 2015-11-16 23:40 +0100
    Re: [PATCH 1/3] mtd: m25p80: fix module autoloading for  "jedec,spi-nor" and "spi-nor" Javier Martinez Canillas <javier@osg.samsung.com> - 2015-11-17 15:00 +0100
  [PATCH 3/3] doc: dt: mtd: stop referring to driver code for spi-nor IDs Brian Norris <computersforpeace@gmail.com> - 2015-11-16 23:40 +0100
    Re: [PATCH 3/3] doc: dt: mtd: stop referring to driver code for  spi-nor IDs Rob Herring <robh@kernel.org> - 2015-11-17 00:20 +0100
    Re: [PATCH 3/3] doc: dt: mtd: stop referring to driver code for  spi-nor IDs Javier Martinez Canillas <javier@osg.samsung.com> - 2015-11-17 15:10 +0100
      Re: [PATCH 3/3] doc: dt: mtd: stop referring to driver code for  spi-nor IDs Brian Norris <computersforpeace@gmail.com> - 2015-11-18 20:50 +0100
        Re: [PATCH 3/3] doc: dt: mtd: stop referring to driver code for  spi-nor IDs Javier Martinez Canillas <javier@osg.samsung.com> - 2015-11-18 21:30 +0100
  Re: [PATCH 0/3] mtd: m25p80: fix some module and documentation issues Brian Norris <computersforpeace@gmail.com> - 2015-11-20 01:50 +0100

csiph-web