[PATCH] ftrace/x86: Add comment on static function tracing

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Namhyung Kim <namhyung@kernel.org>
Newsgroups	linux.kernel
Subject	[PATCH] ftrace/x86: Add comment on static function tracing
Date	Tue, 17 Nov 2015 01:50:01 +0100
Message-ID	<qvCD7-69M-5@gated-at.bofh.it> (permalink)
X-Original-To	Steven Rostedt <rostedt@goodmis.org>
X-Original-Senderip	156.147.1.125
X-Original-Mailfrom	namhyung@kernel.org
X-Original-Senderip	10.177.227.17
X-Original-Mailfrom	namhyung@kernel.org
X-Mailer	git-send-email 2.6.2
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	35
Organization	linux.* mail to news gateway
X-Original-Cc	x86@kernel.org, Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@kernel.org>, "H. Peter Anvin" <hpa@linux.intel.com>, LKML <linux-kernel@vger.kernel.org>
X-Original-Date	Tue, 17 Nov 2015 09:43:24 +0900
X-Original-Message-ID	<1447721004-2551-1-git-send-email-namhyung@kernel.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1270723

Show key headers only | View raw

There was a confusion between update_ftrace_function() and static
function tracing trampoline regarding 3rd parameter (ftrace_ops).
Add a comment for clarification.

Suggested-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
 arch/x86/kernel/mcount_64.S | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/x86/kernel/mcount_64.S b/arch/x86/kernel/mcount_64.S
index 94ea120fa21f..87e1762e2bca 100644
--- a/arch/x86/kernel/mcount_64.S
+++ b/arch/x86/kernel/mcount_64.S
@@ -278,6 +278,12 @@ GLOBAL(ftrace_stub)
 	/* save_mcount_regs fills in first two parameters */
 	save_mcount_regs
 
+	/*
+	 * When DYNAMIC_FTRACE is not defined, ARCH_SUPPORTS_FTRACE_OPS is not
+	 * set (see include/asm/ftrace.h and include/linux/ftrace.h).  Only the
+	 * ip and parent ip are used and the list function is called when
+	 * function tracing is enabled.
+	 */
 	call   *ftrace_trace_function
 
 	restore_mcount_regs
-- 
2.6.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] ftrace/x86: Add comment on static function tracing Namhyung Kim <namhyung@kernel.org> - 2015-11-17 01:50 +0100
  Re: [PATCH] ftrace/x86: Add comment on static function tracing Steven Rostedt <rostedt@goodmis.org> - 2015-11-17 03:10 +0100
  [tip:x86/urgent] x86/ftrace:   Add comment on static function tracing tip-bot for Namhyung Kim <tipbot@zytor.com> - 2015-11-19 11:20 +0100

csiph-web