Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1272993

[tip:x86/urgent] x86/ftrace: Add comment on static function tracing

From tip-bot for Namhyung Kim <tipbot@zytor.com>
Newsgroups linux.kernel
Subject [tip:x86/urgent] x86/ftrace: Add comment on static function tracing
Date 2015-11-19 11:20 +0100
Message-ID <qwutP-7Ys-1@gated-at.bofh.it> (permalink)
References <qvCD7-69M-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Commit-ID:  112677d683d31ebd6a8e8b02e0620ae512354b2d
Gitweb:     http://git.kernel.org/tip/112677d683d31ebd6a8e8b02e0620ae512354b2d
Author:     Namhyung Kim <namhyung@kernel.org>
AuthorDate: Tue, 17 Nov 2015 09:43:24 +0900
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Thu, 19 Nov 2015 11:07:49 +0100

x86/ftrace: Add comment on static function tracing

There was a confusion between update_ftrace_function() and static
function tracing trampoline regarding 3rd parameter (ftrace_ops).
Add a comment for clarification.

Suggested-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Cc: H. Peter Anvin <hpa@linux.intel.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Link: http://lkml.kernel.org/r/1447721004-2551-1-git-send-email-namhyung@kernel.org
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 arch/x86/kernel/mcount_64.S | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/x86/kernel/mcount_64.S b/arch/x86/kernel/mcount_64.S
index 94ea120..87e1762 100644
--- a/arch/x86/kernel/mcount_64.S
+++ b/arch/x86/kernel/mcount_64.S
@@ -278,6 +278,12 @@ trace:
 	/* save_mcount_regs fills in first two parameters */
 	save_mcount_regs
 
+	/*
+	 * When DYNAMIC_FTRACE is not defined, ARCH_SUPPORTS_FTRACE_OPS is not
+	 * set (see include/asm/ftrace.h and include/linux/ftrace.h).  Only the
+	 * ip and parent ip are used and the list function is called when
+	 * function tracing is enabled.
+	 */
 	call   *ftrace_trace_function
 
 	restore_mcount_regs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH] ftrace/x86: Add comment on static function tracing Namhyung Kim <namhyung@kernel.org> - 2015-11-17 01:50 +0100
  Re: [PATCH] ftrace/x86: Add comment on static function tracing Steven Rostedt <rostedt@goodmis.org> - 2015-11-17 03:10 +0100
  [tip:x86/urgent] x86/ftrace:   Add comment on static function tracing tip-bot for Namhyung Kim <tipbot@zytor.com> - 2015-11-19 11:20 +0100

csiph-web