Re: [PATCH V3 02/26] coresight: etm3x: moving sysFS entries to dedicated file

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Mathieu Poirier <mathieu.poirier@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH V3 02/26] coresight: etm3x: moving sysFS entries to dedicated file
Date	Fri, 13 Nov 2015 17:20:02 +0100
Message-ID	<qupeW-eJ-7@gated-at.bofh.it> (permalink)
References	<qtLUd-hJ-3@gated-at.bofh.it> <qtM3T-lk-13@gated-at.bofh.it> <qtMdA-oD-7@gated-at.bofh.it>
X-Original-To	Arnd Bergmann <arnd@arndb.de>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro_org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=C9HgwfxPfi9NVVtssLByyKAOKJF7TwQ/2f8pzNcw9H8=; b=ayuS9LK9akJ7XcoK2c/jay7ortg2CGL9fS/zFXlsQ15OM+4gZgoJo/7iulgafxyCeJ UJrdj5IgprVOdi7hLyXgD/AWJbnVcbBW34dEEokVUZJWl5Y7RgoNtoWXe2irXcTxpF5Y STDW0bp3KY1NriDnUNWC+B7KqoaG4fAZCwjrWZBuLlNZyFVhXMu+7fpqC5UWs33tGZAj KAjj00hTO+iyZMTseFbJohVJtfwA4+NAGPa5bQANovDelRBAUAcZhqPbZfKhoFt1Tg9G 6zL7R5FhK0upAO0lyUgTCdy8/hfvmEb37FnDOZG1ld3XCVcTFodl+sHUUypikJWhvoA3 a4NA==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=C9HgwfxPfi9NVVtssLByyKAOKJF7TwQ/2f8pzNcw9H8=; b=IPOFXzbBeIQ03k3m8Zvy8NgbNmqf0qjDaT2DDXS1ExKZbVhNgrKbf9JU5lTQyF0C+J pOxE7jWuqugNskh9stNKmeCxGHp/HWF5gcMdAK73q+1wn+42JOBVU2OLtQbvHx1MgsDW aBnPy4coCIBw+wXvRCjCF5gdeEAsH1uEpabBbkHy9wdST6vw723FCbXtG9x2q/ASUheX MurL+MN/ipswl85C8OylSXdHqouGTfXgcqZcY718bZlhe7XHDxKSPGLm3wKkRVmCHzD3 NqvcBMJajlFVkvAgq4JAyfH9Ez3crtn/dgXHk6ymT3jnYUdToLG5FtJSE9ETB6bJToBC kV3A==
X-Gm-Message-State	ALoCoQmej8baWC7osxrQKyCLGsi8v8mL3IkrKD+5L4w2IkM3D/jEiFknHzhGkfiGbZWXID5poQPz
MIME-Version	1.0
X-Received	by 10.202.90.137 with SMTP id o131mr12374633oib.83.1447431438708; Fri, 13 Nov 2015 08:17:18 -0800 (PST)
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	33
Organization	linux.* mail to news gateway
X-Original-Cc	"linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, Greg KH <gregkh@linuxfoundation.org>, a.p.zijlstra@chello.nl, Alexander Shishkin <alexander.shishkin@linux.intel.com>, Arnaldo Carvalho de Melo <acme@kernel.org>, Ingo Molnar <mingo@redhat.com>, Jon Corbet <corbet@lwn.net>, Nicolas Pitre <nicolas.pitre@linaro.org>, Al Grant <al.grant@arm.com>, Paweł Moll <pawel.moll@arm.com>, linux-doc@vger.kernel.org, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, fainelli@broadcom.com, Adrian Hunter <adrian.hunter@intel.com>, "Jeremiassen, Tor" <tor@ti.com>, Mike Leach <mike.leach@arm.com>, Chunyan Zhang <zhang.chunyan@linaro.org>
X-Original-Date	Fri, 13 Nov 2015 09:17:18 -0700
X-Original-Message-ID	<CANLsYkyEHEUu6TAgL4Av=Ucvs3U-K3+3J9mHN8=k4LXGLMGGcQ@mail.gmail.com>
X-Original-References	<1447280296-19147-1-git-send-email-mathieu.poirier@linaro.org> <1447280296-19147-3-git-send-email-mathieu.poirier@linaro.org> <4446604.iDni9pkfpc@wuerfel>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1269054

Show key headers only | View raw

On 11 November 2015 at 15:30, Arnd Bergmann <arnd@arndb.de> wrote:
> On Wednesday 11 November 2015 15:17:52 Mathieu Poirier wrote:
>> SysFS entries are big enough to justify their own file.
>> As such moving all sysFS related declarations to a dedicated
>> location.
>>
>> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
>> ---
>>  drivers/hwtracing/coresight/Makefile               |    3 +-
>>  drivers/hwtracing/coresight/coresight-etm.h        |    4 +
>>  .../hwtracing/coresight/coresight-etm3x-sysfs.c    | 1218 +++++++++++++++++++
>>  drivers/hwtracing/coresight/coresight-etm3x.c      | 1234 +-------------------
>>
>
> You are adding a lot of interfaces here, make sure that each one is documented
> in Documentation/ABI/.

Everything is documented in
Documentation/ABI/testing/sysfs-bus-coresight-devices-etm3x.

>
> Your patch series doesn't add anything here, are you just using an existing
> ABI?

That is correct.

>
>         Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH V3 00/26] Coresight integration with perf Mathieu Poirier <mathieu.poirier@linaro.org> - 2015-11-11 23:20 +0100
  [PATCH V3 07/26] coresight: moving PM runtime operations to core framework Mathieu Poirier <mathieu.poirier@linaro.org> - 2015-11-11 23:30 +0100
  [PATCH V3 17/26] coresight: etb10: moving to local atomic operations Mathieu Poirier <mathieu.poirier@linaro.org> - 2015-11-11 23:30 +0100
  [PATCH V3 24/26] perf tools: adding perf_session to *info_prive_size() Mathieu Poirier <mathieu.poirier@linaro.org> - 2015-11-11 23:30 +0100
  [PATCH V3 05/26] coresight: etm3x: implementing 'cpu_id()' API Mathieu Poirier <mathieu.poirier@linaro.org> - 2015-11-11 23:30 +0100
  [PATCH V3 08/26] coresight: etm3x: adding operation mode for etm_enable() Mathieu Poirier <mathieu.poirier@linaro.org> - 2015-11-11 23:30 +0100
  [PATCH V3 23/26] perf tools: making function set_max_cpu_num() non static Mathieu Poirier <mathieu.poirier@linaro.org> - 2015-11-11 23:30 +0100
  [PATCH V3 20/26] coresight: etm-perf: new PMU driver for ETM tracers Mathieu Poirier <mathieu.poirier@linaro.org> - 2015-11-11 23:30 +0100
  [PATCH V3 06/26] coresight: associating path with session rather than tracer Mathieu Poirier <mathieu.poirier@linaro.org> - 2015-11-11 23:30 +0100
  [PATCH V3 11/26] coresight: etm3x: changing default trace configuration Mathieu Poirier <mathieu.poirier@linaro.org> - 2015-11-11 23:30 +0100
  [PATCH V3 25/26] perf tools: making coresight PMU listable Mathieu Poirier <mathieu.poirier@linaro.org> - 2015-11-11 23:30 +0100
  [PATCH V3 12/26] coresight: etm3x: consolidating initial config Mathieu Poirier <mathieu.poirier@linaro.org> - 2015-11-11 23:30 +0100
  [PATCH V3 19/26] coresight: etb10: implementing AUX space API Mathieu Poirier <mathieu.poirier@linaro.org> - 2015-11-11 23:30 +0100
  [PATCH V3 10/26] coresight: etm3x: set progbit to stop trace collection Mathieu Poirier <mathieu.poirier@linaro.org> - 2015-11-11 23:30 +0100
  [PATCH V3 03/26] coresight: etm3x: unlocking tracers in default arch init Mathieu Poirier <mathieu.poirier@linaro.org> - 2015-11-11 23:30 +0100
  [PATCH V3 14/26] coresight: etm3x: adding perf_get/set_config() API Mathieu Poirier <mathieu.poirier@linaro.org> - 2015-11-11 23:30 +0100
  [PATCH V3 09/26] coresight: add API to get sink from path Mathieu Poirier <mathieu.poirier@linaro.org> - 2015-11-11 23:30 +0100
  [PATCH V3 16/26] perf: changing pmu::setup_aux() parameter to include event Mathieu Poirier <mathieu.poirier@linaro.org> - 2015-11-11 23:30 +0100
  [PATCH V3 18/26] coresight: adding operation mode for sink->enable() Mathieu Poirier <mathieu.poirier@linaro.org> - 2015-11-11 23:30 +0100
  [PATCH V3 01/26] coresight: etm3x: moving etm_readl/writel to header file Mathieu Poirier <mathieu.poirier@linaro.org> - 2015-11-11 23:30 +0100
  [PATCH V3 26/26] perf tools: adding coresight etm PMU record capabilities Mathieu Poirier <mathieu.poirier@linaro.org> - 2015-11-11 23:30 +0100
  [PATCH V3 21/26] coresight: introducing a global trace ID function Mathieu Poirier <mathieu.poirier@linaro.org> - 2015-11-11 23:30 +0100
  [PATCH V3 22/26] coresight: updating documentation to reflect integration with perf Mathieu Poirier <mathieu.poirier@linaro.org> - 2015-11-11 23:30 +0100
  Re: [PATCH V3 02/26] coresight: etm3x: moving sysFS entries to dedicated file Arnd Bergmann <arnd@arndb.de> - 2015-11-11 23:40 +0100
    Re: [PATCH V3 02/26] coresight: etm3x: moving sysFS entries to  dedicated file Mathieu Poirier <mathieu.poirier@linaro.org> - 2015-11-13 17:20 +0100
      Re: [PATCH V3 02/26] coresight: etm3x: moving sysFS entries to dedicated file Arnd Bergmann <arnd@arndb.de> - 2015-11-13 17:30 +0100
  Re: [PATCH V3 00/26] Coresight integration with perf Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2015-11-12 12:00 +0100

csiph-web