Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1269450
| From | Anton Bondarenko <anton.bondarenko.sama@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3 2/7] spi: imx: replace fixed timeout with calculated one |
| Date | 2015-11-14 11:10 +0100 |
| Message-ID | <quFWr-2FF-23@gated-at.bofh.it> (permalink) |
| References | <qq27f-166-1@gated-at.bofh.it> <qq27g-166-15@gated-at.bofh.it> <qrop3-4fa-7@gated-at.bofh.it> <qtnIe-1o6-17@gated-at.bofh.it> <qtyNj-ei-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 11.11.2015 09:12, Sascha Hauer wrote:
> On Tue, Nov 10, 2015 at 09:20:06PM +0100, Anton Bondarenko wrote:
>>
>>
>> On 05.11.2015 09:47, Sascha Hauer wrote:
>>>> @@ -890,12 +891,40 @@ static void spi_imx_dma_tx_callback(void *cookie)
>>>> complete(&spi_imx->dma_tx_completion);
>>>> }
>>>>
>>>> +static int spi_imx_calculate_timeout(struct spi_imx_data *spi_imx, int size)
>>>> +{
>>>> + unsigned long coef1 = 1;
>>>> + unsigned long coef2 = MSEC_PER_SEC;
>>>> + unsigned long timeout = 0;
>>>> +
>>>> + /* Swap coeficients to avoid div by 0 */
>>>> + if (spi_imx->spi_bus_clk < MSEC_PER_SEC) {
>>>> + coef1 = MSEC_PER_SEC;
>>>> + coef2 = 1;
>>>> + }
>>>> +
>>>> + /* Time with actual data transfer */
>>>> + timeout += DIV_ROUND_UP(8 * size * coef1,
>>>> + spi_imx->spi_bus_clk / coef2);
>>>> +
>>>> + /* Take CS change delay related to HW */
>>>> + timeout += DIV_ROUND_UP((size - 1) * 4 * coef1,
>>>> + spi_imx->spi_bus_clk / coef2);
>>>> +
>>>> + /* Add extra second for scheduler related activities */
>>>> + timeout += MSEC_PER_SEC;
>>>> +
>>>> + /* Double calculated timeout */
>>>> + return msecs_to_jiffies(2 * timeout);
>>>> +}
>>>
>>> I think you can simplify this function to:
>>>
>>> timeout = size * 8 / spi_imx->spi_bus_clk;
>>> timeout += 2;
>>>
>>> return msecs_to_jiffies(timeout * MSEC_PER_SEC);
>>>
>>> The rationale is that when size * 8 / spi_imx->spi_bus_clk is 0 then we
>>> can add another second and be fine. No need to calculate this more
>>> accurate, in the end it's important to catch the timeout. If we do this
>>> one or two seconds too late doesn't matter.
>>>
>>> Sascha
>>>
>>
>> Sascha,
>>
>> What about something like this:
>> timeout = size * (8 + 4) / spi_imx->spi_bus_clk;
>> timeout += 2;
>>
>> return msecs_to_jiffies(2 * timeout * MSEC_PER_SEC);
>>
>> I think we still need to take into account 4 CLKs between each burst.
>
> Fine with me.
>
> Sascha
>
>
Tested new implementation successfully. Will be V4 patchset. Does anyone
has other comments regarding this commit?
Regards, Anton
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH v3 0/7] Improvements for SPI IMX driver for Freescale IMX51, IMX53 and IMX6 Anton Bondarenko <anton.bondarenko.sama@gmail.com> - 2015-11-01 15:50 +0100
[PATCH v3 5/7] spi: imx: Add support for loopback for ECSPI controllers Anton Bondarenko <anton.bondarenko.sama@gmail.com> - 2015-11-01 15:50 +0100
Re: [PATCH v3 5/7] spi: imx: Add support for loopback for ECSPI controllers Anton Bondarenko <anton.bondarenko.sama@gmail.com> - 2015-11-14 11:10 +0100
[PATCH v3 6/7] spi: imx: return error from dma channel request Anton Bondarenko <anton.bondarenko.sama@gmail.com> - 2015-11-01 15:50 +0100
Re: [PATCH v3 6/7] spi: imx: return error from dma channel request Sascha Hauer <s.hauer@pengutronix.de> - 2015-11-05 10:00 +0100
Re: [PATCH v3 6/7] spi: imx: return error from dma channel request Anton Bondarenko <anton.bondarenko.sama@gmail.com> - 2015-11-05 17:10 +0100
Re: [PATCH v3 6/7] spi: imx: return error from dma channel request Anton Bondarenko <anton.bondarenko.sama@gmail.com> - 2015-11-14 11:10 +0100
Re: [PATCH v3 6/7] spi: imx: return error from dma channel request Anton Bondarenko <anton.bondarenko.sama@gmail.com> - 2015-11-14 11:10 +0100
[PATCH v3 4/7] spi: imx: add function to check for IMX51 family controller Anton Bondarenko <anton.bondarenko.sama@gmail.com> - 2015-11-01 15:50 +0100
Re: [PATCH v3 4/7] spi: imx: add function to check for IMX51 family controller Anton Bondarenko <anton.bondarenko.sama@gmail.com> - 2015-11-14 11:10 +0100
[PATCH v3 3/7] spi: imx: add support for all SPI word width for DMA transfer Anton Bondarenko <anton.bondarenko.sama@gmail.com> - 2015-11-01 15:50 +0100
[PATCH v3 1/7] spi: imx: Fix DMA transfer Anton Bondarenko <anton.bondarenko.sama@gmail.com> - 2015-11-01 15:50 +0100
Re: [PATCH v3 1/7] spi: imx: Fix DMA transfer Anton Bondarenko <anton.bondarenko.sama@gmail.com> - 2015-11-04 22:10 +0100
Re: [PATCH v3 1/7] spi: imx: Fix DMA transfer Sascha Hauer <s.hauer@pengutronix.de> - 2015-11-05 09:40 +0100
Re: [PATCH v3 1/7] spi: imx: Fix DMA transfer Anton Bondarenko <anton.bondarenko.sama@gmail.com> - 2015-11-05 18:00 +0100
Re: [PATCH v3 1/7] spi: imx: Fix DMA transfer Anton Bondarenko <anton.bondarenko.sama@gmail.com> - 2015-11-14 11:10 +0100
[PATCH v3 7/7] spi: imx: defer spi initialization, if DMA engine is pending Anton Bondarenko <anton.bondarenko.sama@gmail.com> - 2015-11-01 15:50 +0100
Re: [PATCH v3 7/7] spi: imx: defer spi initialization, if DMA engine is pending Sascha Hauer <s.hauer@pengutronix.de> - 2015-11-05 10:00 +0100
Re: [PATCH v3 7/7] spi: imx: defer spi initialization, if DMA engine is pending Anton Bondarenko <anton.bondarenko.sama@gmail.com> - 2015-11-05 17:20 +0100
Re: [PATCH v3 7/7] spi: imx: defer spi initialization, if DMA engine is pending Anton Bondarenko <anton.bondarenko.sama@gmail.com> - 2015-11-14 11:10 +0100
[PATCH v3 2/7] spi: imx: replace fixed timeout with calculated one Anton Bondarenko <anton.bondarenko.sama@gmail.com> - 2015-11-01 15:50 +0100
Re: [PATCH v3 2/7] spi: imx: replace fixed timeout with calculated one Sascha Hauer <s.hauer@pengutronix.de> - 2015-11-05 09:50 +0100
Re: [PATCH v3 2/7] spi: imx: replace fixed timeout with calculated one Anton Bondarenko <anton.bondarenko.sama@gmail.com> - 2015-11-10 21:30 +0100
Re: [PATCH v3 2/7] spi: imx: replace fixed timeout with calculated one Sascha Hauer <s.hauer@pengutronix.de> - 2015-11-11 09:20 +0100
Re: [PATCH v3 2/7] spi: imx: replace fixed timeout with calculated one Anton Bondarenko <anton.bondarenko.sama@gmail.com> - 2015-11-14 11:10 +0100
csiph-web