Re: [PATCH] null_blk: Register as a LightNVM device

From	Jens Axboe <axboe@fb.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] null_blk: Register as a LightNVM device
Date	2015-11-12 17:00 +0100
Message-ID	<qu2s1-2lX-9@gated-at.bofh.it> (permalink)
References	<qtAvM-1p6-19@gated-at.bofh.it> <qtVTB-6Fg-25@gated-at.bofh.it> <qu2in-2in-39@gated-at.bofh.it> <qu2s1-2lX-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 11/12/2015 08:52 AM, Christoph Hellwig wrote:
> On Thu, Nov 12, 2015 at 08:49:08AM -0700, Jens Axboe wrote:
>> But it still avoids duplicating the generics of it. Patch for null_blk:
>>
>> 3 files changed, 168 insertions(+), 7 deletions (-)
>>
>> vs a standalone of:
>>
>> 3 files changed, 459 insertions(+)
>>
>> It doesn't screw up null_blk, so I'd prefer just adding it as an on-the-side
>> mode for that.
>
> 300 lines of boilerplate for just setting up a few request_queues seem
> wrong, can you show the actual patch you measured?

I just took it from Matias' last posting:

http://marc.info/?l=linux-kernel&m=144605858228534&w=2

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH] null_blk: Register as a LightNVM device Matias Bjørling <m@bjorling.me> - 2015-11-11 11:10 +0100
  Re: [PATCH] null_blk: Register as a LightNVM device Jens Axboe <axboe@kernel.dk> - 2015-11-11 22:30 +0100
    Re: [PATCH] null_blk: Register as a LightNVM device Jens Axboe <axboe@kernel.dk> - 2015-11-11 23:20 +0100
      Re: [PATCH] null_blk: Register as a LightNVM device Matias Bjørling <m@bjorling.me> - 2015-11-12 12:40 +0100
  Re: [PATCH] null_blk: Register as a LightNVM device Christoph Hellwig <hch@infradead.org> - 2015-11-12 10:00 +0100
    Re: [PATCH] null_blk: Register as a LightNVM device Jens Axboe <axboe@kernel.dk> - 2015-11-12 16:50 +0100
      Re: [PATCH] null_blk: Register as a LightNVM device Christoph Hellwig <hch@infradead.org> - 2015-11-12 17:00 +0100
        Re: [PATCH] null_blk: Register as a LightNVM device Jens Axboe <axboe@fb.com> - 2015-11-12 17:10 +0100
          Re: [PATCH] null_blk: Register as a LightNVM device Matias Bjørling <m@bjorling.me> - 2015-11-12 19:30 +0100
      Re: [PATCH] null_blk: Register as a LightNVM device Jens Axboe <axboe@fb.com> - 2015-11-12 17:00 +0100
      Re: [PATCH] null_blk: Register as a LightNVM device Christoph Hellwig <hch@infradead.org> - 2015-11-12 17:00 +0100

csiph-web