Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1268063

Re: [PATCH] null_blk: Register as a LightNVM device

Show all headers | View raw

On 11/12/2015 08:58 AM, Christoph Hellwig wrote:
> On Thu, Nov 12, 2015 at 08:54:48AM -0700, Jens Axboe wrote:
>>> 300 lines of boilerplate for just setting up a few request_queues seem
>>> wrong, can you show the actual patch you measured?
>>
>> I just took it from Matias' last posting:
>>
>> http://marc.info/?l=linux-kernel&m=144605858228534&w=2
>
> Well, that one has all these crazy completion methods which
> are of no use for a blk-mq driver, so it should really be
> compared without those.

So we can cut it down a bit, it's still going to be the same boilerplate 
code that null_blk has, even with just mq completions. If it ended up 
rewriting null_blk to be something else entirely or full of ifdef 
sprinkles, I'd agree. But for adding a hundred lines of code to be able 
to test lightnvm perf, I think it's  a no-brainer to just add it to 
null_blk and not have a separate module.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] null_blk: Register as a LightNVM device Matias Bjørling <m@bjorling.me> - 2015-11-11 11:10 +0100
  Re: [PATCH] null_blk: Register as a LightNVM device Jens Axboe <axboe@kernel.dk> - 2015-11-11 22:30 +0100
    Re: [PATCH] null_blk: Register as a LightNVM device Jens Axboe <axboe@kernel.dk> - 2015-11-11 23:20 +0100
      Re: [PATCH] null_blk: Register as a LightNVM device Matias Bjørling <m@bjorling.me> - 2015-11-12 12:40 +0100
  Re: [PATCH] null_blk: Register as a LightNVM device Christoph Hellwig <hch@infradead.org> - 2015-11-12 10:00 +0100
    Re: [PATCH] null_blk: Register as a LightNVM device Jens Axboe <axboe@kernel.dk> - 2015-11-12 16:50 +0100
      Re: [PATCH] null_blk: Register as a LightNVM device Christoph Hellwig <hch@infradead.org> - 2015-11-12 17:00 +0100
        Re: [PATCH] null_blk: Register as a LightNVM device Jens Axboe <axboe@fb.com> - 2015-11-12 17:10 +0100
          Re: [PATCH] null_blk: Register as a LightNVM device Matias Bjørling <m@bjorling.me> - 2015-11-12 19:30 +0100
      Re: [PATCH] null_blk: Register as a LightNVM device Jens Axboe <axboe@fb.com> - 2015-11-12 17:00 +0100
      Re: [PATCH] null_blk: Register as a LightNVM device Christoph Hellwig <hch@infradead.org> - 2015-11-12 17:00 +0100

csiph-web