Re: [PATCH] arm64: bpf: fix JIT stack setup

From	Z Lim <zlim.lnx@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] arm64: bpf: fix JIT stack setup
Date	2015-11-11 04:20 +0100
Message-ID	<qtu6Z-5GD-5@gated-at.bofh.it> (permalink)
References	(1 earlier) <qsnTY-2aP-3@gated-at.bofh.it> <qsGMW-6dI-23@gated-at.bofh.it> <qsZ3d-1rz-25@gated-at.bofh.it> <qt0Vl-2FZ-23@gated-at.bofh.it> <qtn5v-Uo-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Nov 10, 2015 at 11:46 AM, Shi, Yang <yang.shi@linaro.org> wrote:
> On 11/9/2015 12:00 PM, Z Lim wrote:
>>
>> How about splitting this into two patches? One for the BPF-related
>> bug, and another for A64 FP-handling.
>
> I'm not sure if this is a good approach or not. IMHO, they are kind of
> atomic. Without A64 FP-handling, that fix looks incomplete and introduces
> another problem (stack backtrace).
>

The first, even on its own, doesn't make things worse, only better.
The second, which we agree needs to be fixed also, addresses a different issue.

Either way, please also note that these patches fix the original
implementation. We do want -stable to pick these up.

Suggestions for the diagram:
- As an enhancement, would you mind showing the A64_FP also?
- Please revisit "+64:"
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] arm64: bpf: fix JIT stack setup Yang Shi <yang.shi@linaro.org> - 2015-11-07 07:00 +0100
  Re: [PATCH] arm64: bpf: fix JIT stack setup Alexei Starovoitov <alexei.starovoitov@gmail.com> - 2015-11-08 03:30 +0100
    Re: [PATCH] arm64: bpf: fix JIT stack setup Z Lim <zlim.lnx@gmail.com> - 2015-11-08 23:40 +0100
      Re: [PATCH] arm64: bpf: fix JIT stack setup "Shi, Yang" <yang.shi@linaro.org> - 2015-11-09 19:10 +0100
        Re: [PATCH] arm64: bpf: fix JIT stack setup Z Lim <zlim.lnx@gmail.com> - 2015-11-09 21:10 +0100
          Re: [PATCH] arm64: bpf: fix JIT stack setup "Shi, Yang" <yang.shi@linaro.org> - 2015-11-10 20:50 +0100
            Re: [PATCH] arm64: bpf: fix JIT stack setup Z Lim <zlim.lnx@gmail.com> - 2015-11-11 04:20 +0100

csiph-web