Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1267754

Re: [RFC 1/4] iio: ina2xx: add direct IO support for TI INA2xx Power Monitors

Show all headers | View raw

On 11/11/2015 13:09, Daniel Baluta wrote:
> <snip>
>
>> Signed-off-by: Marc Titinger <mtitinger@baylibre.com>
>> ---
>>   drivers/iio/adc/Kconfig      |   9 +
>>   drivers/iio/adc/Makefile     |   1 +
>>   drivers/iio/adc/ina2xx-iio.c | 404 +++++++++++++++++++++++++++++++++++++++++++
>
> One more thing. In IIO we do not prefer generic names for files.
> Lets name this after the first device in the family.
>
> Here I would say we should call it drivers/iio/adc/ina219.c. Skip the
> -iio suffix
> from file name, because it is already under the iio/ directory.

I get your point, but in this specific case there is already support for 
this chip family in hwmon and both drivers make sense because both 
applications exist (hardware monitoring or power measurement equipement).

To avoid confusion it may be good to have at least a common radix for 
the CONFIG option, so that searching returns both options.

>
> If there is a module name conflict with hwmon module we can name the
> .ko resulted
> from this file ina219-iio.ko.
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC 0/4] IIO: add support for INA2xx power monitor Marc Titinger <mtitinger@baylibre.com> - 2015-11-10 17:10 +0100
  [RFC 1/4] iio: ina2xx: add direct IO support for TI INA2xx Power Monitors Marc Titinger <mtitinger@baylibre.com> - 2015-11-10 17:10 +0100
    Re: [RFC 1/4] iio: ina2xx: add direct IO support for TI INA2xx Power Monitors Daniel Baluta <daniel.baluta@gmail.com> - 2015-11-11 11:20 +0100
      Re: [RFC 1/4] iio: ina2xx: add direct IO support for TI INA2xx Power  Monitors Marc Titinger <mtitinger@baylibre.com> - 2015-11-12 10:30 +0100
    Re: [RFC 1/4] iio: ina2xx: add direct IO support for TI INA2xx Power Monitors Daniel Baluta <daniel.baluta@gmail.com> - 2015-11-11 13:20 +0100
      Re: [RFC 1/4] iio: ina2xx: add direct IO support for TI INA2xx Power  Monitors Marc Titinger <mtitinger@baylibre.com> - 2015-11-12 10:40 +0100
      [RFC v2 1/2] iio: ina2xx: add direct IO support for TI INA2xx Power Monitors Marc Titinger <mtitinger@baylibre.com> - 2015-11-12 14:00 +0100
        [RFC v2 2/2] iio: ina2xx: add SOFTWARE buffer mode using an iio kfifo. Marc Titinger <mtitinger@baylibre.com> - 2015-11-12 14:00 +0100
        Re: [RFC v2 1/2] iio: ina2xx: add direct IO support for TI INA2xx  Power Monitors Jonathan Cameron <jic23@kernel.org> - 2015-11-14 20:10 +0100
          Re: [RFC v2 1/2] iio: ina2xx: add direct IO support for TI INA2xx  Power Monitors Marc Titinger <mtitinger@baylibre.com> - 2015-11-16 10:40 +0100
  [RFC 4/4] iio: ina2xx: add SOFTWARE buffer mode using an iio kfifo. Marc Titinger <mtitinger@baylibre.com> - 2015-11-10 17:10 +0100
    Re: [RFC 4/4] iio: ina2xx: add SOFTWARE buffer mode using an iio  kfifo. Lars-Peter Clausen <lars@metafoo.de> - 2015-11-10 19:30 +0100
      Re: [RFC 4/4] iio: ina2xx: add SOFTWARE buffer mode using an iio  kfifo. Marc Titinger <mtitinger@baylibre.com> - 2015-11-12 11:20 +0100
        Re: [RFC 4/4] iio: ina2xx: add SOFTWARE buffer mode using an iio  kfifo. Lars-Peter Clausen <lars@metafoo.de> - 2015-11-12 11:30 +0100
        Re: [RFC 4/4] iio: ina2xx: add SOFTWARE buffer mode using an iio  kfifo. Jonathan Cameron <jic23@kernel.org> - 2015-11-14 19:50 +0100
          Re: [RFC 4/4] iio: ina2xx: add SOFTWARE buffer mode using an iio  kfifo. Marc Titinger <mtitinger@baylibre.com> - 2015-11-16 10:40 +0100
  [RFC 2/4] iio: ina2xx: add SAMP_FREQ attribute. Marc Titinger <mtitinger@baylibre.com> - 2015-11-10 17:10 +0100
    Re: [RFC 2/4] iio: ina2xx: add SAMP_FREQ attribute. Daniel Baluta <daniel.baluta@gmail.com> - 2015-11-11 11:20 +0100

csiph-web