Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1267172

Re: [PATCH RESEND 06/25] mpt3sas: Define 'hba_mpi_version_belonged' IOC variable

From Hannes Reinecke <hare@suse.de>
Newsgroups linux.kernel
Subject Re: [PATCH RESEND 06/25] mpt3sas: Define 'hba_mpi_version_belonged' IOC variable
Date 2015-11-11 14:00 +0100
Message-ID <qtDai-2Sb-11@gated-at.bofh.it> (permalink)
References <qtCnT-2Ba-3@gated-at.bofh.it> <qtCnV-2Ba-37@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 11/11/2015 01:00 PM, Sreekanth Reddy wrote:
> From: Sreekanth Reddy <sreekanth.reddy@avagotech.com>
> 
> 1. Use 'hba_mpi_version_belonged' IOC varable to uniquely
> identify each individual generation driver functionality at
> runtime.
> 
> 2. Declared global variable 'driver_name' and used
> this variable while reserving PCI regions and while
> allocating the IRQ's.
> 
> Signed-off-by: Sreekanth Reddy <Sreekanth.Reddy@avagotech.com>
> ---
>  drivers/scsi/mpt2sas/mpt2sas_module.c |  1 +
>  drivers/scsi/mpt3sas/mpt3sas_base.c   |  8 +++----
>  drivers/scsi/mpt3sas/mpt3sas_base.h   |  3 +++
>  drivers/scsi/mpt3sas/mpt3sas_ctl.c    | 18 +++++++++++++---
>  drivers/scsi/mpt3sas/mpt3sas_module.c |  1 +
>  drivers/scsi/mpt3sas/mpt3sas_scsih.c  | 39 ++++++++++++++++++++++++++++++++++-
>  6 files changed, 62 insertions(+), 8 deletions(-)
> 
I'd rather shorten that to 'hba_mpi_version'.

Other than that it's okay.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		               zSeries & Storage
hare@suse.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 00/25] mpt3sas: Mergering mpt2sas & mpt3sas driver code Sreekanth Reddy <sreekanth.reddy@avagotech.com> - 2015-11-11 13:10 +0100
  [PATCH RESEND 07/25] mpt2sas, mpt3sas : Removed SCSI_MPTXSAS_LOGGING entry from Kconfig Sreekanth Reddy <sreekanth.reddy@avagotech.com> - 2015-11-11 13:10 +0100
  [PATCH 25/25] mpt3sas: Bump mpt3sas driver version to 09.102.00.00 Sreekanth Reddy <sreekanth.reddy@avagotech.com> - 2015-11-11 13:10 +0100
  [PATCH RESEND 06/25] mpt3sas: Define 'hba_mpi_version_belonged' IOC variable Sreekanth Reddy <sreekanth.reddy@avagotech.com> - 2015-11-11 13:10 +0100
    Re: [PATCH RESEND 06/25] mpt3sas: Define 'hba_mpi_version_belonged'  IOC variable Hannes Reinecke <hare@suse.de> - 2015-11-11 14:00 +0100
  [PATCH 24/25] mpt3sas: Added SCSI_MPT3SAS_MERGED config option Sreekanth Reddy <sreekanth.reddy@avagotech.com> - 2015-11-11 13:10 +0100
  [PATCH RESEND 08/25] mpt3sas: For an IO, build MPI SGL LIST on GEN2 HBA's and build IEEE SGL LIST on GEN3 HBA's Sreekanth Reddy <sreekanth.reddy@avagotech.com> - 2015-11-11 13:10 +0100
  [PATCH 22/25] mpt3sas: Added a module parameter hbas_to_enumerate Sreekanth Reddy <sreekanth.reddy@avagotech.com> - 2015-11-11 13:10 +0100
  [PATCH RESEND 18/25] mpt2sas, mpt3sas: Update the driver versions Sreekanth Reddy <sreekanth.reddy@avagotech.com> - 2015-11-11 13:10 +0100
  [PATCH RESEND 10/25] mpt3sas: Manage MSIX vectors according to HBA device type Sreekanth Reddy <sreekanth.reddy@avagotech.com> - 2015-11-11 13:10 +0100
  [PATCH RESEND 13/25] mpt3sas: Ported the providing sysfs attribute to report Backup Rail Monitor Status Sreekanth Reddy <sreekanth.reddy@avagotech.com> - 2015-11-11 13:10 +0100
  [PATCH 23/25] mpt2sas: Removed mpt2sas entries from SCSI's Kconfig and Makefile Sreekanth Reddy <sreekanth.reddy@avagotech.com> - 2015-11-11 13:10 +0100
  [PATCH RESEND 03/25] mpt3sas: Move Gen3 HBA's device registration with PCI, SML and IOCTL related API's to a separate file Sreekanth Reddy <sreekanth.reddy@avagotech.com> - 2015-11-11 13:10 +0100
  Re: [PATCH 00/25] mpt3sas: Mergering mpt2sas & mpt3sas driver code Hannes Reinecke <hare@suse.de> - 2015-11-11 14:10 +0100
  Re: [PATCH 00/25] mpt3sas: Mergering mpt2sas & mpt3sas driver code "Martin K. Petersen" <martin.petersen@oracle.com> - 2015-11-12 02:20 +0100
    Re: [PATCH 00/25] mpt3sas: Mergering mpt2sas & mpt3sas driver code Yinghai Lu <yinghai@kernel.org> - 2015-11-12 21:10 +0100
      Re: [PATCH 00/25] mpt3sas: Mergering mpt2sas & mpt3sas driver code "Martin K. Petersen" <martin.petersen@oracle.com> - 2015-11-13 21:30 +0100

csiph-web