Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1267190

Re: [PATCH v2 1/7] timekeeping: introduce __current_kernel_time64

Show key headers only | View raw

On Wednesday 11 November 2015 11:51:26 Stefano Stabellini wrote:
> On Tue, 10 Nov 2015, Thomas Gleixner wrote:
> > On Tue, 10 Nov 2015, John Stultz wrote:
> > > I'm sort of objecting to a different issue, where the
> > > __current_kernel_time() implementation probably shouldn't be grabbing
> > > the tk_core.timekeeper directly, and instead should take a passed
> > > pointer to a timekeeper. The vdso/pv_clock usage should have a
> > > timekeeper passed to them that they could use.
> > 
> > That usage of __current_kernel_time() in that xen notifier is silly to
> > begin with. The notifier gets already called with a pointer to the
> > time keeper. That xen implementation just does not use it.
> >
> > We extract exactly that information in the vdso updates without
> > calling back into the core code. So for solving that xen thing we do
> > not need a 64 bit variant of __current_kernel_time() at all. The
> > notifier has the pointer to the timekeeper and can just grab data from
> > there.
> 
> Many thanks for the suggestion, I'll do that.
> Should I open code tk_xtime in the xen notifier, or should I export it
> in timekeeper_internal.h?

tk_xtime is a 'static inline' function, I don't see a good way to
make that accessible, and you really want the elements separately,
so I'd open-code it without going through timespec64.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/7] Xen wallclock on arm and arm64 Stefano Stabellini <stefano.stabellini@eu.citrix.com> - 2015-11-10 13:00 +0100
  [PATCH v2 3/7] xen/arm: introduce HYPERVISOR_platform_op on arm and arm64 Stefano Stabellini <stefano.stabellini@eu.citrix.com> - 2015-11-10 13:00 +0100
  [PATCH v2 1/7] timekeeping: introduce __current_kernel_time64 Stefano Stabellini <stefano.stabellini@eu.citrix.com> - 2015-11-10 13:00 +0100
    Re: [PATCH v2 1/7] timekeeping: introduce __current_kernel_time64 Peter Zijlstra <peterz@infradead.org> - 2015-11-10 13:30 +0100
      Re: [PATCH v2 1/7] timekeeping: introduce __current_kernel_time64 Stefano Stabellini <stefano.stabellini@eu.citrix.com> - 2015-11-10 15:40 +0100
    Re: [PATCH v2 1/7] timekeeping: introduce __current_kernel_time64 Arnd Bergmann <arnd@arndb.de> - 2015-11-10 13:40 +0100
      Re: [PATCH v2 1/7] timekeeping: introduce __current_kernel_time64 Stefano Stabellini <stefano.stabellini@eu.citrix.com> - 2015-11-10 16:20 +0100
        Re: [PATCH v2 1/7] timekeeping: introduce __current_kernel_time64 John Stultz <john.stultz@linaro.org> - 2015-11-10 16:30 +0100
          Re: [PATCH v2 1/7] timekeeping: introduce __current_kernel_time64 Thomas Gleixner <tglx@linutronix.de> - 2015-11-10 16:40 +0100
            Re: [PATCH v2 1/7] timekeeping: introduce __current_kernel_time64 John Stultz <john.stultz@linaro.org> - 2015-11-10 16:50 +0100
              Re: [PATCH v2 1/7] timekeeping: introduce __current_kernel_time64 Thomas Gleixner <tglx@linutronix.de> - 2015-11-10 17:00 +0100
                Re: [PATCH v2 1/7] timekeeping: introduce __current_kernel_time64 Stefano Stabellini <stefano.stabellini@eu.citrix.com> - 2015-11-11 13:00 +0100
                Re: [PATCH v2 1/7] timekeeping: introduce __current_kernel_time64 Arnd Bergmann <arnd@arndb.de> - 2015-11-11 14:40 +0100
  [PATCH v2 4/7] xen: introduce XENPF_settime64 Stefano Stabellini <stefano.stabellini@eu.citrix.com> - 2015-11-10 13:00 +0100
    Re: [PATCH v2 4/7] xen: introduce XENPF_settime64 Arnd Bergmann <arnd@arndb.de> - 2015-11-10 13:40 +0100
      Re: [PATCH v2 4/7] xen: introduce XENPF_settime64 Arnd Bergmann <arnd@arndb.de> - 2015-11-10 15:50 +0100
      Re: [PATCH v2 4/7] xen: introduce XENPF_settime64 Stefano Stabellini <stefano.stabellini@eu.citrix.com> - 2015-11-10 15:50 +0100
  [PATCH v2 6/7] xen/arm: introduce xen_read_wallclock Stefano Stabellini <stefano.stabellini@eu.citrix.com> - 2015-11-10 13:00 +0100
    Re: [PATCH v2 6/7] xen/arm: introduce xen_read_wallclock Arnd Bergmann <arnd@arndb.de> - 2015-11-10 13:40 +0100
  [PATCH v2 7/7] xen/arm: set the system time in Xen via the XENPF_settime64 hypercall Stefano Stabellini <stefano.stabellini@eu.citrix.com> - 2015-11-10 13:00 +0100
    Re: [PATCH v2 7/7] xen/arm: set the system time in Xen via the XENPF_settime64 hypercall Arnd Bergmann <arnd@arndb.de> - 2015-11-10 13:50 +0100
      Re: [PATCH v2 7/7] xen/arm: set the system time in Xen via the  XENPF_settime64 hypercall Stefano Stabellini <stefano.stabellini@eu.citrix.com> - 2015-11-10 17:00 +0100
  [PATCH v2 2/7] xen: rename dom0_op to platform_op Stefano Stabellini <stefano.stabellini@eu.citrix.com> - 2015-11-10 13:00 +0100

csiph-web