Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1266551

Re: [PATCH v2 4/7] xen: introduce XENPF_settime64

Show all headers | View raw

On Tue, 10 Nov 2015, Arnd Bergmann wrote:
> On Tuesday 10 November 2015 11:57:52 Stefano Stabellini wrote:
> > Rename the current XENPF_settime hypercall and related struct to
> > XENPF_settime32.
> > 
> > Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> > CC: konrad.wilk@oracle.com
> > CC: david.vrabel@citrix.com
> > CC: boris.ostrovsky@oracle.com
> 
> Looks good.

Can I add your acked-by?


> > ---
> >  arch/x86/xen/time.c              |    8 ++++----
> >  include/xen/interface/platform.h |   18 ++++++++++++++----
> >  2 files changed, 18 insertions(+), 8 deletions(-)
> > 
> > diff --git a/arch/x86/xen/time.c b/arch/x86/xen/time.c
> > index 663c2ea..3bbd377 100644
> > --- a/arch/x86/xen/time.c
> > +++ b/arch/x86/xen/time.c
> > @@ -134,10 +134,10 @@ static int xen_pvclock_gtod_notify(struct notifier_block *nb,
> >         if (!was_set && timespec_compare(&now, &next_sync) < 0)
> >                 return NOTIFY_OK;
> >  
> > -       op.cmd = XENPF_settime;
> > -       op.u.settime.secs = now.tv_sec;
> > -       op.u.settime.nsecs = now.tv_nsec;
> > -       op.u.settime.system_time = xen_clocksource_read();
> > +       op.cmd = XENPF_settime32;
> > +       op.u.settime32.secs = now.tv_sec;
> > +       op.u.settime32.nsecs = now.tv_nsec;
> > +       op.u.settime32.system_time = xen_clocksource_read();
> >  
> >         (void)HYPERVISOR_platform_op(&op);
> 
> I suppose someone will have to get back to this eventually and
> change the code to try XENPF_settime64 first.

I'll leave that to the x86 maintainers
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/7] Xen wallclock on arm and arm64 Stefano Stabellini <stefano.stabellini@eu.citrix.com> - 2015-11-10 13:00 +0100
  [PATCH v2 3/7] xen/arm: introduce HYPERVISOR_platform_op on arm and arm64 Stefano Stabellini <stefano.stabellini@eu.citrix.com> - 2015-11-10 13:00 +0100
  [PATCH v2 1/7] timekeeping: introduce __current_kernel_time64 Stefano Stabellini <stefano.stabellini@eu.citrix.com> - 2015-11-10 13:00 +0100
    Re: [PATCH v2 1/7] timekeeping: introduce __current_kernel_time64 Peter Zijlstra <peterz@infradead.org> - 2015-11-10 13:30 +0100
      Re: [PATCH v2 1/7] timekeeping: introduce __current_kernel_time64 Stefano Stabellini <stefano.stabellini@eu.citrix.com> - 2015-11-10 15:40 +0100
    Re: [PATCH v2 1/7] timekeeping: introduce __current_kernel_time64 Arnd Bergmann <arnd@arndb.de> - 2015-11-10 13:40 +0100
      Re: [PATCH v2 1/7] timekeeping: introduce __current_kernel_time64 Stefano Stabellini <stefano.stabellini@eu.citrix.com> - 2015-11-10 16:20 +0100
        Re: [PATCH v2 1/7] timekeeping: introduce __current_kernel_time64 John Stultz <john.stultz@linaro.org> - 2015-11-10 16:30 +0100
          Re: [PATCH v2 1/7] timekeeping: introduce __current_kernel_time64 Thomas Gleixner <tglx@linutronix.de> - 2015-11-10 16:40 +0100
            Re: [PATCH v2 1/7] timekeeping: introduce __current_kernel_time64 John Stultz <john.stultz@linaro.org> - 2015-11-10 16:50 +0100
              Re: [PATCH v2 1/7] timekeeping: introduce __current_kernel_time64 Thomas Gleixner <tglx@linutronix.de> - 2015-11-10 17:00 +0100
                Re: [PATCH v2 1/7] timekeeping: introduce __current_kernel_time64 Stefano Stabellini <stefano.stabellini@eu.citrix.com> - 2015-11-11 13:00 +0100
                Re: [PATCH v2 1/7] timekeeping: introduce __current_kernel_time64 Arnd Bergmann <arnd@arndb.de> - 2015-11-11 14:40 +0100
  [PATCH v2 4/7] xen: introduce XENPF_settime64 Stefano Stabellini <stefano.stabellini@eu.citrix.com> - 2015-11-10 13:00 +0100
    Re: [PATCH v2 4/7] xen: introduce XENPF_settime64 Arnd Bergmann <arnd@arndb.de> - 2015-11-10 13:40 +0100
      Re: [PATCH v2 4/7] xen: introduce XENPF_settime64 Arnd Bergmann <arnd@arndb.de> - 2015-11-10 15:50 +0100
      Re: [PATCH v2 4/7] xen: introduce XENPF_settime64 Stefano Stabellini <stefano.stabellini@eu.citrix.com> - 2015-11-10 15:50 +0100
  [PATCH v2 6/7] xen/arm: introduce xen_read_wallclock Stefano Stabellini <stefano.stabellini@eu.citrix.com> - 2015-11-10 13:00 +0100
    Re: [PATCH v2 6/7] xen/arm: introduce xen_read_wallclock Arnd Bergmann <arnd@arndb.de> - 2015-11-10 13:40 +0100
  [PATCH v2 7/7] xen/arm: set the system time in Xen via the XENPF_settime64 hypercall Stefano Stabellini <stefano.stabellini@eu.citrix.com> - 2015-11-10 13:00 +0100
    Re: [PATCH v2 7/7] xen/arm: set the system time in Xen via the XENPF_settime64 hypercall Arnd Bergmann <arnd@arndb.de> - 2015-11-10 13:50 +0100
      Re: [PATCH v2 7/7] xen/arm: set the system time in Xen via the  XENPF_settime64 hypercall Stefano Stabellini <stefano.stabellini@eu.citrix.com> - 2015-11-10 17:00 +0100
  [PATCH v2 2/7] xen: rename dom0_op to platform_op Stefano Stabellini <stefano.stabellini@eu.citrix.com> - 2015-11-10 13:00 +0100

csiph-web