Re: [dm-devel] [RFC PATCH 00/32] separate operations from flags in the bio/request structs

From	Christoph Hellwig <hch@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [dm-devel] [RFC PATCH 00/32] separate operations from flags in the bio/request structs
Date	2015-11-11 12:30 +0100
Message-ID	<qtBLb-27c-5@gated-at.bofh.it> (permalink)
References	<qr9gm-2Ro-11@gated-at.bofh.it> <qram6-3wQ-11@gated-at.bofh.it> <qram6-3wQ-9@gated-at.bofh.it> <qs8UX-11D-33@gated-at.bofh.it> <qtytX-8jJ-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Nov 11, 2015 at 01:53:24AM -0600, Mike Christie wrote:
> We no longer have the bvec merge functions so the original reason given
> in the thread/patch Bart referenced is no longer valid.
> 
> Offlist it was suggested that dropping the argument from submit_bio
> might still improve performance, but I modified xfs and dm and did some
> testing and did not see anything.
> 
> So the change is not needed, and it would only be done because people
> feel it would improve the interface.

I would defintively prefer the changed interface, and to me it also
looks like it would make your overall patch simpler.  If you disagree
feel free to keep it as-is for now and I'll do another pass later.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[RFC PATCH 00/32] separate operations from flags in the bio/request structs mchristi@redhat.com - 2015-11-04 17:40 +0100
  [PATCH 03/32] dio/btrfs: prep dio->submit_bio users for bi_rw split. mchristi@redhat.com - 2015-11-04 17:40 +0100
  Re: [dm-devel] [RFC PATCH 00/32] separate operations from flags in  the bio/request structs Mike Christie <michaelc@cs.wisc.edu> - 2015-11-04 18:50 +0100
    Re: [dm-devel] [RFC PATCH 00/32] separate operations from flags in  the bio/request structs Christoph Hellwig <hch@infradead.org> - 2015-11-07 11:30 +0100
      Re: [dm-devel] [RFC PATCH 00/32] separate operations from flags in  the bio/request structs Mike Christie <michaelc@cs.wisc.edu> - 2015-11-11 09:00 +0100
        Re: [dm-devel] [RFC PATCH 00/32] separate operations from flags in  the bio/request structs Christoph Hellwig <hch@infradead.org> - 2015-11-11 12:30 +0100
          Re: [RFC PATCH 00/32] separate operations from flags in the  bio/request structs Mike Snitzer <snitzer@redhat.com> - 2015-11-11 18:40 +0100

csiph-web