Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1264804

Re: [dm-devel] [RFC PATCH 00/32] separate operations from flags in the bio/request structs

Show all headers | View raw

On Wed, Nov 04, 2015 at 10:53:39AM -0600, Mike Christie wrote:
> > If you have to touch submit_bio() and submit_bio_wait(), how about
> > requiring the callers of these functions to set the cmd and flags
> > arguments in the bio structure and to leave out the cmd and flags
> > arguments from the submit_bio() and submit_bio_wait() functions ? A
> > (compile tested only) patch that implements this idea is available at
> > https://lkml.org/lkml/2014/6/2/173.
> > 
> 
> Yeah, I can do that.

I think this would be useful to do at the beginning of the series.
While this will have a huge trickle effect through the series it should
make thing a bit simpler overall.  By leaving op 0 undefined it should
also help to create a nice error trap for unconverted code.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH 00/32] separate operations from flags in the bio/request structs mchristi@redhat.com - 2015-11-04 17:40 +0100
  [PATCH 03/32] dio/btrfs: prep dio->submit_bio users for bi_rw split. mchristi@redhat.com - 2015-11-04 17:40 +0100
  Re: [dm-devel] [RFC PATCH 00/32] separate operations from flags in  the bio/request structs Mike Christie <michaelc@cs.wisc.edu> - 2015-11-04 18:50 +0100
    Re: [dm-devel] [RFC PATCH 00/32] separate operations from flags in  the bio/request structs Christoph Hellwig <hch@infradead.org> - 2015-11-07 11:30 +0100
      Re: [dm-devel] [RFC PATCH 00/32] separate operations from flags in  the bio/request structs Mike Christie <michaelc@cs.wisc.edu> - 2015-11-11 09:00 +0100
        Re: [dm-devel] [RFC PATCH 00/32] separate operations from flags in  the bio/request structs Christoph Hellwig <hch@infradead.org> - 2015-11-11 12:30 +0100
          Re: [RFC PATCH 00/32] separate operations from flags in the  bio/request structs Mike Snitzer <snitzer@redhat.com> - 2015-11-11 18:40 +0100

csiph-web