Re: [PATCH V3 3/4] dmaselftest: add memcpy selftest support functions

From	Sinan Kaya <okaya@codeaurora.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH V3 3/4] dmaselftest: add memcpy selftest support functions
Date	2015-11-10 06:00 +0100
Message-ID	<qt9ce-nP-29@gated-at.bofh.it> (permalink)
References	<qsqf8-3JB-11@gated-at.bofh.it> <qsqf8-3JB-15@gated-at.bofh.it> <qsErL-4Ks-7@gated-at.bofh.it> <qsL0d-Bm-7@gated-at.bofh.it> <qsQVY-4xo-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 11/9/2015 4:26 AM, Andy Shevchenko wrote:
> On Mon, Nov 9, 2015 at 5:07 AM, Sinan Kaya <okaya@codeaurora.org> wrote:
>>
>>
>> On 11/8/2015 3:09 PM, Andy Shevchenko wrote:
>>>
>>> On Sun, Nov 8, 2015 at 6:52 AM, Sinan Kaya <okaya@codeaurora.org> wrote:
>>>>
>>>> This patch adds supporting utility functions
>>>> for selftest. The intention is to share the self
>>>> test code between different drivers.
>>>>
>>>> Supported test cases include:
>>>> 1. dma_map_single
>>>> 2. streaming DMA
>>>> 3. coherent DMA
>>>> 4. scatter-gather DMA
>>>
>>>
>
>>>> +       u32 i, j = 0;
>>>
>>> unsigned int
>>
>> why?
>
> Is i or j is going to be used for HW communication? No? What about
> assignment to a values of type u32? No? Plain counters? Use plain
> types.

OK. I did an internal code review before posting the patch. Nobody 
complained about iterator types. I am trying to find what goes as a good 
practice vs. what is personal style.

>
> It's actually comment about your all patches I saw last week.
>
>>>> +       int err = 0;
>>>> +       int ret;
>>>
>>>
>>> Any reason to have two instead of one of similar meaning?
>>>
>>
>> removed ret
>
> Don't forget to check if it's redundant assignment (check in all your
> patches as well).
>

I'll look.

-- 
Sinan Kaya
Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a 
Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH V3 3/4] dmaselftest: add memcpy selftest support functions Sinan Kaya <okaya@codeaurora.org> - 2015-11-08 06:00 +0100
  Re: [PATCH V3 3/4] dmaselftest: add memcpy selftest support functions Timur Tabi <timur@codeaurora.org> - 2015-11-08 06:20 +0100
    Re: [PATCH V3 3/4] dmaselftest: add memcpy selftest support functions Sinan Kaya <okaya@codeaurora.org> - 2015-11-09 03:50 +0100
      Re: [PATCH V3 3/4] dmaselftest: add memcpy selftest support functions Timur Tabi <timur@codeaurora.org> - 2015-11-09 14:50 +0100
        Re: [PATCH V3 3/4] dmaselftest: add memcpy selftest support functions Sinan Kaya <okaya@codeaurora.org> - 2015-11-10 06:00 +0100
          Re: [PATCH V3 3/4] dmaselftest: add memcpy selftest support functions Arnd Bergmann <arnd@arndb.de> - 2015-11-10 11:20 +0100
  Re: [PATCH V3 3/4] dmaselftest: add memcpy selftest support functions Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-11-08 21:10 +0100
    Re: [PATCH V3 3/4] dmaselftest: add memcpy selftest support functions Sinan Kaya <okaya@codeaurora.org> - 2015-11-09 04:10 +0100
      Re: [PATCH V3 3/4] dmaselftest: add memcpy selftest support functions Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-11-09 10:30 +0100
        Re: [PATCH V3 3/4] dmaselftest: add memcpy selftest support functions Timur Tabi <timur@codeaurora.org> - 2015-11-10 06:00 +0100
        Re: [PATCH V3 3/4] dmaselftest: add memcpy selftest support functions Sinan Kaya <okaya@codeaurora.org> - 2015-11-10 06:00 +0100

csiph-web