Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1266246

Re: [PATCH V3 3/4] dmaselftest: add memcpy selftest support functions

From Timur Tabi <timur@codeaurora.org>
Newsgroups linux.kernel
Subject Re: [PATCH V3 3/4] dmaselftest: add memcpy selftest support functions
Date 2015-11-10 06:00 +0100
Message-ID <qt9ce-nP-27@gated-at.bofh.it> (permalink)
References (1 earlier) <qsqf8-3JB-15@gated-at.bofh.it> <qsErL-4Ks-7@gated-at.bofh.it> <qsL0d-Bm-7@gated-at.bofh.it> <qsQVY-4xo-21@gated-at.bofh.it> <qt9ce-nP-29@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Sinan Kaya wrote:
>
> OK. I did an internal code review before posting the patch. Nobody
> complained about iterator types. I am trying to find what goes as a good
> practice vs. what is personal style.

I normally check for inappropriate usage of sized integers in my 
reviews, but I admit I'm inconsistent about that sort of thing for 
internal reviews.

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the
Code Aurora Forum, hosted by The Linux Foundation.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH V3 3/4] dmaselftest: add memcpy selftest support functions Sinan Kaya <okaya@codeaurora.org> - 2015-11-08 06:00 +0100
  Re: [PATCH V3 3/4] dmaselftest: add memcpy selftest support functions Timur Tabi <timur@codeaurora.org> - 2015-11-08 06:20 +0100
    Re: [PATCH V3 3/4] dmaselftest: add memcpy selftest support functions Sinan Kaya <okaya@codeaurora.org> - 2015-11-09 03:50 +0100
      Re: [PATCH V3 3/4] dmaselftest: add memcpy selftest support functions Timur Tabi <timur@codeaurora.org> - 2015-11-09 14:50 +0100
        Re: [PATCH V3 3/4] dmaselftest: add memcpy selftest support functions Sinan Kaya <okaya@codeaurora.org> - 2015-11-10 06:00 +0100
          Re: [PATCH V3 3/4] dmaselftest: add memcpy selftest support functions Arnd Bergmann <arnd@arndb.de> - 2015-11-10 11:20 +0100
  Re: [PATCH V3 3/4] dmaselftest: add memcpy selftest support functions Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-11-08 21:10 +0100
    Re: [PATCH V3 3/4] dmaselftest: add memcpy selftest support functions Sinan Kaya <okaya@codeaurora.org> - 2015-11-09 04:10 +0100
      Re: [PATCH V3 3/4] dmaselftest: add memcpy selftest support functions Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-11-09 10:30 +0100
        Re: [PATCH V3 3/4] dmaselftest: add memcpy selftest support functions Timur Tabi <timur@codeaurora.org> - 2015-11-10 06:00 +0100
        Re: [PATCH V3 3/4] dmaselftest: add memcpy selftest support functions Sinan Kaya <okaya@codeaurora.org> - 2015-11-10 06:00 +0100

csiph-web