Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1266055

Re: [PATCH] staging: lustre: acl: fix ifnullfree.cocci warnings

Show all headers | View raw

On Mon, 9 Nov 2015, Greg KH wrote:

> On Tue, Nov 10, 2015 at 03:43:50AM +0800, kbuild test robot wrote:
> > drivers/staging/lustre/lustre/llite/xattr.c:199:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.
> >
> >  NULL check before some freeing functions is not needed.
> >
> >  Based on checkpatch warning
> >  "kfree(NULL) is safe this check is probably not required"
> >  and kfreeaddr.cocci by Julia Lawall.
> >
> > Generated by: scripts/coccinelle/free/ifnullfree.cocci
> >
> > CC: Shivani Bhardwaj <shivanib134@gmail.com>
> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> > ---
> >
> >  xattr.c |    3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > --- a/drivers/staging/lustre/lustre/llite/xattr.c
> > +++ b/drivers/staging/lustre/lustre/llite/xattr.c
> > @@ -192,11 +192,10 @@ int ll_setxattr_common(struct inode *ino
> >  			 valid, name, pv, size, 0, flags,
> >  			 ll_i2suppgid(inode), &req);
> >  #ifdef CONFIG_FS_POSIX_ACL
> > -	if (new_value != NULL)
> >  		/*
> >  		 * Release the posix ACL space.
> >  		 */
> > -		kfree(new_value);
> > +	kfree(new_value);
>
> Looks like a bug in coccinelle, the comment line should also be indented
> to the left.
>
> Julia, any ideas?

I think it's on the border of what the person is going to have to resign
themselves to doing by hand.  I'm not sure which side of the border it is
on, but I try to focus more on getting the code printed in the right place
than on the comments.  I can check on it, though, and maybe an easy fix is
possible.

thanks,
julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] staging: lustre: acl: Remove lustre_posix_acl_xattr_free wrapper Shivani Bhardwaj <shivanib134@gmail.com> - 2015-11-09 20:00 +0100
  Re: [PATCH] staging: lustre: acl: Remove lustre_posix_acl_xattr_free  wrapper kbuild test robot <lkp@intel.com> - 2015-11-09 20:50 +0100
  [PATCH] staging: lustre: acl: fix ifnullfree.cocci warnings kbuild test robot <lkp@intel.com> - 2015-11-09 20:50 +0100
    Re: [PATCH] staging: lustre: acl: fix ifnullfree.cocci warnings Greg KH <gregkh@linuxfoundation.org> - 2015-11-09 21:00 +0100
      Re: [PATCH] staging: lustre: acl: fix ifnullfree.cocci warnings Julia Lawall <julia.lawall@lip6.fr> - 2015-11-09 23:10 +0100

csiph-web