Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1265972
| From | kbuild test robot <lkp@intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH] staging: lustre: acl: fix ifnullfree.cocci warnings |
| Date | 2015-11-09 20:50 +0100 |
| Message-ID | <qt0BY-2jS-39@gated-at.bofh.it> (permalink) |
| References | <qt0BX-2jS-7@gated-at.bofh.it> <qsZPA-1LJ-21@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
drivers/staging/lustre/lustre/llite/xattr.c:199:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. NULL check before some freeing functions is not needed. Based on checkpatch warning "kfree(NULL) is safe this check is probably not required" and kfreeaddr.cocci by Julia Lawall. Generated by: scripts/coccinelle/free/ifnullfree.cocci CC: Shivani Bhardwaj <shivanib134@gmail.com> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> --- xattr.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/staging/lustre/lustre/llite/xattr.c +++ b/drivers/staging/lustre/lustre/llite/xattr.c @@ -192,11 +192,10 @@ int ll_setxattr_common(struct inode *ino valid, name, pv, size, 0, flags, ll_i2suppgid(inode), &req); #ifdef CONFIG_FS_POSIX_ACL - if (new_value != NULL) /* * Release the posix ACL space. */ - kfree(new_value); + kfree(new_value); if (acl != NULL) lustre_ext_acl_xattr_free(acl); #endif -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] staging: lustre: acl: Remove lustre_posix_acl_xattr_free wrapper Shivani Bhardwaj <shivanib134@gmail.com> - 2015-11-09 20:00 +0100
Re: [PATCH] staging: lustre: acl: Remove lustre_posix_acl_xattr_free wrapper kbuild test robot <lkp@intel.com> - 2015-11-09 20:50 +0100
[PATCH] staging: lustre: acl: fix ifnullfree.cocci warnings kbuild test robot <lkp@intel.com> - 2015-11-09 20:50 +0100
Re: [PATCH] staging: lustre: acl: fix ifnullfree.cocci warnings Greg KH <gregkh@linuxfoundation.org> - 2015-11-09 21:00 +0100
Re: [PATCH] staging: lustre: acl: fix ifnullfree.cocci warnings Julia Lawall <julia.lawall@lip6.fr> - 2015-11-09 23:10 +0100
csiph-web