Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1265049

[PATCH v3 06/10] thermal: rockchip: consistently use int for temperatures

Show key headers only | View raw

As Temperature is currently represented as int not long in the thermal
framework since use int intead of unsigned long/long to represent temperature
to avoid bogus overheat detection when negative temperature reported.

Signed-off-by: Caesar Wang <wxt@rock-chips.com>

---

Changes in v3:
- As the Patch v2 comments, Add a new patch to fix it.

Changes in v2: None
Changes in v1: None

 drivers/thermal/rockchip_thermal.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/thermal/rockchip_thermal.c b/drivers/thermal/rockchip_thermal.c
index c1ab346..067ecdd 100644
--- a/drivers/thermal/rockchip_thermal.c
+++ b/drivers/thermal/rockchip_thermal.c
@@ -87,7 +87,7 @@ struct rockchip_tsadc_chip {
 	int chn_num;
 
 	/* The hardware-controlled tshut property */
-	long tshut_temp;
+	int tshut_temp;
 	enum tshut_mode tshut_mode;
 	enum tshut_polarity tshut_polarity;
 
@@ -100,7 +100,7 @@ struct rockchip_tsadc_chip {
 	int (*get_temp)(struct chip_tsadc_table table,
 			int chn, void __iomem *reg, int *temp);
 	void (*set_tshut_temp)(struct chip_tsadc_table table,
-			       int chn, void __iomem *reg, long temp);
+			       int chn, void __iomem *reg, int temp);
 	void (*set_tshut_mode)(int chn, void __iomem *reg, enum tshut_mode m);
 
 	/* Per-table methods */
@@ -125,7 +125,7 @@ struct rockchip_thermal_data {
 
 	void __iomem *regs;
 
-	long tshut_temp;
+	int tshut_temp;
 	enum tshut_mode tshut_mode;
 	enum tshut_polarity tshut_polarity;
 };
@@ -159,7 +159,7 @@ struct rockchip_thermal_data {
 
 struct tsadc_table {
 	u32 code;
-	long temp;
+	int temp;
 };
 
 static const struct tsadc_table v2_code_table[] = {
@@ -201,7 +201,7 @@ static const struct tsadc_table v2_code_table[] = {
 };
 
 static u32 rk_tsadcv2_temp_to_code(struct chip_tsadc_table table,
-				   long temp)
+				   int temp)
 {
 	int high, low, mid;
 
@@ -355,7 +355,7 @@ static int rk_tsadcv2_get_temp(struct chip_tsadc_table table,
 }
 
 static void rk_tsadcv2_tshut_temp(struct chip_tsadc_table table,
-				  int chn, void __iomem *regs, long temp)
+				  int chn, void __iomem *regs, int temp)
 {
 	u32 tshut_value, val;
 
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 00/10] Better compatible for the rockchip thermal and support RK3368 SoCs Caesar Wang <wxt@rock-chips.com> - 2015-11-08 10:30 +0100
  [PATCH v3 10/10] arm64: dts: Enable the Thermal on R88 board Caesar Wang <wxt@rock-chips.com> - 2015-11-08 10:30 +0100
    Re: [PATCH v3 10/10] arm64: dts: Enable the Thermal on R88 board kbuild test robot <lkp@intel.com> - 2015-11-08 14:50 +0100
  [PATCH v3 01/10] dt-bindings: rockchip-thermal: Support the RK3368 SoCs compatible Caesar Wang <wxt@rock-chips.com> - 2015-11-08 10:30 +0100
  [PATCH v3 06/10] thermal: rockchip: consistently use int for temperatures Caesar Wang <wxt@rock-chips.com> - 2015-11-08 10:30 +0100
  [PATCH v3 02/10] thermal: rockchip: better to compatible the driver for different SoCs Caesar Wang <wxt@rock-chips.com> - 2015-11-08 10:30 +0100
  [PATCH v3 04/10] thermal: rockchip: improve the conversion function Caesar Wang <wxt@rock-chips.com> - 2015-11-08 10:30 +0100
  [PATCH v3 07/10] thermal: rockchip: Support the RK3368 SoCs in thermal drivers Caesar Wang <wxt@rock-chips.com> - 2015-11-08 10:30 +0100
  [PATCH v3 05/10] thermal: rockchip: Add the sort flag for adc value increment or decrement Caesar Wang <wxt@rock-chips.com> - 2015-11-08 10:30 +0100
    Re: [PATCH v3 05/10] thermal: rockchip: Add the sort flag for adc  value increment or decrement kbuild test robot <lkp@intel.com> - 2015-11-08 10:50 +0100
  [PATCH v3 08/10] arm64: dts: Add the thermal data found on RK3368 Caesar Wang <wxt@rock-chips.com> - 2015-11-08 10:30 +0100
  [PATCH v3 09/10] arm64: dts: Add main Thermal info to rk3368.dtsi Caesar Wang <wxt@rock-chips.com> - 2015-11-08 10:30 +0100
  [PATCH v3 03/10] thermal: rockchip: trivial: fix typo in commit Caesar Wang <wxt@rock-chips.com> - 2015-11-08 10:40 +0100

csiph-web