Re: [PATCH 0/2] mmc: sdhci: potentially bad behavior when using vmmc supply

From	Ulf Hansson <ulf.hansson@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 0/2] mmc: sdhci: potentially bad behavior when using vmmc supply
Date	2015-11-09 12:00 +0100
Message-ID	<qsSl4-5kw-5@gated-at.bofh.it> (permalink)
References	<qrRAL-6pR-25@gated-at.bofh.it> <qrSn7-6Y7-9@gated-at.bofh.it> <qsPnb-3rE-5@gated-at.bofh.it> <qsR5E-4AF-39@gated-at.bofh.it> <qsRS1-598-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[...]

>>
>> This doesn't seems like a case where a gpio regulator should be used
>> and I am not sure what problem it would solve. Beside to suppress the
>> log warnings (actually those aren't warnings but informations).
>>
>> Isn't sdhci_do_start_signal_voltage_switch() doing what you need here?
>>
>
> It is. I am only wondering the best way to describe the hardware:
> - No regulator but I have the 'no vqmmc regulator not found' message which
>   is a bit annoying and which can be interpreted as an issue for someone
>   who has no knowledge about this stuff.

Hmm, should we turn them into debug messages? Both regulators are optional.

> - Describe the regulator since there is one on my board. But it is not a
>   fixed regulator and even if it's close to a gpio one it is not.

If it's driven by SDHCI internal logic, I would leave it to that.
There are no need to describe it at all.

Kind regards
Uffe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 0/2] mmc: sdhci: potentially bad behavior when using vmmc supply Ludovic Desroches <ludovic.desroches@atmel.com> - 2015-11-06 17:00 +0100
  [PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power Ludovic Desroches <ludovic.desroches@atmel.com> - 2015-11-06 17:10 +0100
    Re: [PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power Ludovic Desroches <ludovic.desroches@atmel.com> - 2015-11-09 14:30 +0100
      Re: [PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power Ulf Hansson <ulf.hansson@linaro.org> - 2015-11-09 15:20 +0100
        Re: [PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power Ludovic Desroches <ludovic.desroches@atmel.com> - 2015-11-09 15:50 +0100
          Re: [PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power Ulf Hansson <ulf.hansson@linaro.org> - 2015-11-09 17:10 +0100
            Re: [PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power Ludovic Desroches <ludovic.desroches@atmel.com> - 2015-11-09 17:40 +0100
  [PATCH 2/2] ARM: at91/dt: sama5d2 Xplained: add regulators for sdhci devices Ludovic Desroches <ludovic.desroches@atmel.com> - 2015-11-06 17:10 +0100
  Re: [PATCH 0/2] mmc: sdhci: potentially bad behavior when using vmmc supply Ulf Hansson <ulf.hansson@linaro.org> - 2015-11-06 17:50 +0100
    Re: [PATCH 0/2] mmc: sdhci: potentially bad behavior when using vmmc  supply Ludovic Desroches <ludovic.desroches@atmel.com> - 2015-11-09 08:50 +0100
      Re: [PATCH 0/2] mmc: sdhci: potentially bad behavior when using vmmc supply Ulf Hansson <ulf.hansson@linaro.org> - 2015-11-09 10:40 +0100
        Re: [PATCH 0/2] mmc: sdhci: potentially bad behavior when using vmmc  supply Ludovic Desroches <ludovic.desroches@atmel.com> - 2015-11-09 11:30 +0100
          Re: [PATCH 0/2] mmc: sdhci: potentially bad behavior when using vmmc supply Ulf Hansson <ulf.hansson@linaro.org> - 2015-11-09 12:00 +0100
            Re: [PATCH 0/2] mmc: sdhci: potentially bad behavior when using vmmc  supply Ludovic Desroches <ludovic.desroches@atmel.com> - 2015-11-09 14:20 +0100
              Re: [PATCH 0/2] mmc: sdhci: potentially bad behavior when using vmmc supply Ulf Hansson <ulf.hansson@linaro.org> - 2015-11-09 14:20 +0100

csiph-web