RE: [PATCH] PCI: pcie-rcar: Fix OF node passed to MSI irq domain

From	Phil Edworthy <phil.edworthy@renesas.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH] PCI: pcie-rcar: Fix OF node passed to MSI irq domain
Date	2015-11-09 10:10 +0100
Message-ID	<qsQCC-4p4-15@gated-at.bofh.it> (permalink)
References	<qqGo3-WT-39@gated-at.bofh.it> <qsclP-3jn-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Wolfram,

On 07 November 2015 14:00, Wolfram wrote:
> On Tue, Nov 03, 2015 at 09:28:19AM +0000, Phil Edworthy wrote:
> > The OF node passed to irq_domain_add_linear() should be a
> > pointer to interrupt controller's device tree node, or NULL,
> > but not the PCI controller's node.
> >
> > This fixes an oops in msi_domain_alloc_irqs() when it tries
> > to call msi_check().
> >
> > Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>
> 
> Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> 
> Was this the MSI problem you were talking about?
Yes, that was the one.

Thanks for the review & test.
Phil
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH] PCI: pcie-rcar: Fix OF node passed to MSI irq domain Phil Edworthy <phil.edworthy@renesas.com> - 2015-11-03 10:50 +0100
  Re: [PATCH] PCI: pcie-rcar: Fix OF node passed to MSI irq domain Wolfram Sang <wsa@the-dreams.de> - 2015-11-07 15:10 +0100
    RE: [PATCH] PCI: pcie-rcar: Fix OF node passed to MSI irq domain Phil Edworthy <phil.edworthy@renesas.com> - 2015-11-09 10:10 +0100
    Re: [PATCH] PCI: pcie-rcar: Fix OF node passed to MSI irq domain Simon Horman <horms@verge.net.au> - 2015-11-10 02:30 +0100
  RE: [PATCH] PCI: pcie-rcar: Fix OF node passed to MSI irq domain Phil Edworthy <phil.edworthy@renesas.com> - 2015-11-09 16:30 +0100
    Re: [PATCH] PCI: pcie-rcar: Fix OF node passed to MSI irq domain Thierry Reding <treding@nvidia.com> - 2015-11-09 17:20 +0100
      RE: [PATCH] PCI: pcie-rcar: Fix OF node passed to MSI irq domain Phil Edworthy <phil.edworthy@renesas.com> - 2015-11-09 18:30 +0100
      RE: [PATCH] PCI: pcie-rcar: Fix OF node passed to MSI irq domain Phil Edworthy <phil.edworthy@renesas.com> - 2015-11-09 19:10 +0100
        Re: [PATCH] PCI: pcie-rcar: Fix OF node passed to MSI irq domain Thierry Reding <treding@nvidia.com> - 2015-11-10 17:00 +0100
          Re: [PATCH] PCI: pcie-rcar: Fix OF node passed to MSI irq domain Marc Zyngier <marc.zyngier@arm.com> - 2015-11-11 17:40 +0100
            RE: [PATCH] PCI: pcie-rcar: Fix OF node passed to MSI irq domain Phil Edworthy <phil.edworthy@renesas.com> - 2015-11-12 10:00 +0100
              Re: [PATCH] PCI: pcie-rcar: Fix OF node passed to MSI irq domain Marc Zyngier <marc.zyngier@arm.com> - 2015-11-12 21:40 +0100
                RE: [PATCH] PCI: pcie-rcar: Fix OF node passed to MSI irq domain Phil Edworthy <phil.edworthy@renesas.com> - 2015-11-13 10:40 +0100

csiph-web