Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1261346
| From | Phil Edworthy <phil.edworthy@renesas.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH] PCI: pcie-rcar: Fix OF node passed to MSI irq domain |
| Date | 2015-11-03 10:50 +0100 |
| Message-ID | <qqGo3-WT-39@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
The OF node passed to irq_domain_add_linear() should be a
pointer to interrupt controller's device tree node, or NULL,
but not the PCI controller's node.
This fixes an oops in msi_domain_alloc_irqs() when it tries
to call msi_check().
Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>
---
drivers/pci/host/pcie-rcar.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/host/pcie-rcar.c b/drivers/pci/host/pcie-rcar.c
index 2377bf0..c6fa562 100644
--- a/drivers/pci/host/pcie-rcar.c
+++ b/drivers/pci/host/pcie-rcar.c
@@ -709,7 +709,7 @@ static int rcar_pcie_enable_msi(struct rcar_pcie *pcie)
msi->chip.setup_irq = rcar_msi_setup_irq;
msi->chip.teardown_irq = rcar_msi_teardown_irq;
- msi->domain = irq_domain_add_linear(pcie->dev->of_node, INT_PCI_MSI_NR,
+ msi->domain = irq_domain_add_linear(NULL, INT_PCI_MSI_NR,
&msi_domain_ops, &msi->chip);
if (!msi->domain) {
dev_err(&pdev->dev, "failed to create IRQ domain\n");
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH] PCI: pcie-rcar: Fix OF node passed to MSI irq domain Phil Edworthy <phil.edworthy@renesas.com> - 2015-11-03 10:50 +0100
Re: [PATCH] PCI: pcie-rcar: Fix OF node passed to MSI irq domain Wolfram Sang <wsa@the-dreams.de> - 2015-11-07 15:10 +0100
RE: [PATCH] PCI: pcie-rcar: Fix OF node passed to MSI irq domain Phil Edworthy <phil.edworthy@renesas.com> - 2015-11-09 10:10 +0100
Re: [PATCH] PCI: pcie-rcar: Fix OF node passed to MSI irq domain Simon Horman <horms@verge.net.au> - 2015-11-10 02:30 +0100
RE: [PATCH] PCI: pcie-rcar: Fix OF node passed to MSI irq domain Phil Edworthy <phil.edworthy@renesas.com> - 2015-11-09 16:30 +0100
Re: [PATCH] PCI: pcie-rcar: Fix OF node passed to MSI irq domain Thierry Reding <treding@nvidia.com> - 2015-11-09 17:20 +0100
RE: [PATCH] PCI: pcie-rcar: Fix OF node passed to MSI irq domain Phil Edworthy <phil.edworthy@renesas.com> - 2015-11-09 18:30 +0100
RE: [PATCH] PCI: pcie-rcar: Fix OF node passed to MSI irq domain Phil Edworthy <phil.edworthy@renesas.com> - 2015-11-09 19:10 +0100
Re: [PATCH] PCI: pcie-rcar: Fix OF node passed to MSI irq domain Thierry Reding <treding@nvidia.com> - 2015-11-10 17:00 +0100
Re: [PATCH] PCI: pcie-rcar: Fix OF node passed to MSI irq domain Marc Zyngier <marc.zyngier@arm.com> - 2015-11-11 17:40 +0100
RE: [PATCH] PCI: pcie-rcar: Fix OF node passed to MSI irq domain Phil Edworthy <phil.edworthy@renesas.com> - 2015-11-12 10:00 +0100
Re: [PATCH] PCI: pcie-rcar: Fix OF node passed to MSI irq domain Marc Zyngier <marc.zyngier@arm.com> - 2015-11-12 21:40 +0100
RE: [PATCH] PCI: pcie-rcar: Fix OF node passed to MSI irq domain Phil Edworthy <phil.edworthy@renesas.com> - 2015-11-13 10:40 +0100
csiph-web