Re: [PATCH] gpio: 104-idio-16: Use lowercase symbol names for const variables

From	Alexandre Courbot <gnurou@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] gpio: 104-idio-16: Use lowercase symbol names for const variables
Date	2015-11-09 07:20 +0100
Message-ID	<qsNY6-2He-1@gated-at.bofh.it> (permalink)
References	<qr5w5-pT-1@gated-at.bofh.it> <qsI2m-6WE-7@gated-at.bofh.it> <qsJrr-7YA-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Nov 9, 2015 at 10:28 AM, William Breathitt Gray
<vilhelm.gray@gmail.com> wrote:
> On 11/08/2015 06:53 PM, Alexandre Courbot wrote:
>> Apart from that this patch seems harmless and the repositioning of
>> some constant declarations is also welcome.
>
> I'll create a separate patch to reposition the constant declarations. Where in
> particular do you believe would be best for them to be positioned?

I was talking about what you did here:

@@ -109,24 +109,23 @@ static int __init idio_16_probe(struct
platform_device *pdev)
 {
        struct device *dev = &pdev->dev;
        struct idio_16_gpio *idio16gpio;
+       const unsigned base = idio_16_base;
+       const unsigned extent = 8;
+       const char *const name = dev_name(dev);
        int err;

-       const unsigned BASE = idio_16_base;
-       const unsigned EXTENT = 8;
-       const char *const NAME = dev_name(dev);

So this is already done - sorry for not having been clear.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] gpio: 104-idio-16: Use lowercase symbol names for const  variables William Breathitt Gray <vilhelm.gray@gmail.com> - 2015-11-04 13:40 +0100
  Re: [PATCH] gpio: 104-idio-16: Use lowercase symbol names for const variables Alexandre Courbot <gnurou@gmail.com> - 2015-11-09 01:00 +0100
    Re: [PATCH] gpio: 104-idio-16: Use lowercase symbol names for const  variables William Breathitt Gray <vilhelm.gray@gmail.com> - 2015-11-09 02:30 +0100
      Re: [PATCH] gpio: 104-idio-16: Use lowercase symbol names for const variables Alexandre Courbot <gnurou@gmail.com> - 2015-11-09 07:20 +0100

csiph-web