Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1265252

Re: [PATCH] gpio: 104-idio-16: Use lowercase symbol names for const variables

Show all headers | View raw

On Wed, Nov 4, 2015 at 9:30 PM, William Breathitt Gray
<vilhelm.gray@gmail.com> wrote:
> To prevent confusion and to match existing coding style used in other
> gpio drivers symbol names within the 104-idio-16 gpio driver should be
> lowercase.

... and for the same styling reasons "GPIO" should be spelled in
uppercase in your commit message. ;)

Apart from that this patch seems harmless and the repositioning of
some constant declarations is also welcome.

Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] gpio: 104-idio-16: Use lowercase symbol names for const  variables William Breathitt Gray <vilhelm.gray@gmail.com> - 2015-11-04 13:40 +0100
  Re: [PATCH] gpio: 104-idio-16: Use lowercase symbol names for const variables Alexandre Courbot <gnurou@gmail.com> - 2015-11-09 01:00 +0100
    Re: [PATCH] gpio: 104-idio-16: Use lowercase symbol names for const  variables William Breathitt Gray <vilhelm.gray@gmail.com> - 2015-11-09 02:30 +0100
      Re: [PATCH] gpio: 104-idio-16: Use lowercase symbol names for const variables Alexandre Courbot <gnurou@gmail.com> - 2015-11-09 07:20 +0100

csiph-web