Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1264773

Re: [PATCH] Preserve task state in reentrant calls to ___wait_event

Show all headers | View raw

On Fri, Nov 06, 2015 at 08:44:08PM +0000, Chris Bainbridge wrote:
> I am assuming here that wait_event_timeout() is supposed to support reentrant
> calls.

Not really. It is sort of allowed, provided the inner one will rarely
block. And therefore the outer one will mostly work.

> If not, perhaps it should BUG_ON when called with a non-running task
> state,

There is a warning in __might_sleep() that catches some of this.

> and the SBS HC / ACPI EC code needs to be fixed to stop doing this.

Yes.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] Preserve task state in reentrant calls to ___wait_event Chris Bainbridge <chris.bainbridge@gmail.com> - 2015-11-06 21:50 +0100
  Re: [PATCH] Preserve task state in reentrant calls to ___wait_event "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-11-06 23:40 +0100
    [PATCH] ACPI / SMBus: Fix boot stalls / high CPU caused by reentrant  code Chris Bainbridge <chris.bainbridge@gmail.com> - 2015-11-12 19:10 +0100
    [PATCH] Revert "ACPI / SBS: Add 5 us delay to fix SBS hangs on  MacBook" Chris Bainbridge <chris.bainbridge@gmail.com> - 2015-11-12 20:30 +0100
  Re: [PATCH] Preserve task state in reentrant calls to ___wait_event Chris Bainbridge <chris.bainbridge@gmail.com> - 2015-11-07 09:40 +0100
  Re: [PATCH] Preserve task state in reentrant calls to ___wait_event Peter Zijlstra <peterz@infradead.org> - 2015-11-07 10:30 +0100

csiph-web