Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1264772

Re: [PATCH] of: Provide static inline function for of_translate_address if needed

Show all headers | View raw

On Friday 06 November 2015 19:28:22 Guenter Roeck wrote:
> If OF_ADDRESS is not configured, builds can fail with errors such as
> 
> drivers/net/ethernet/hisilicon/hns_mdio.c:
> 	In function 'hns_mdio_bus_name':
> drivers/net/ethernet/hisilicon/hns_mdio.c:411:3:
> 	error: implicit declaration of function 'of_translate_address'
> 
> as currently seen when building sparc:allmodconfig.
> 
> Introduce a static inline function if OF_ADDRESS is not configured to fix
> the build failure. Return OF_BAD_ADDR in this case. For this to work, the
> definition of OF_BAD_ADDR has to be moved outside CONFIG_OF conditional
> code.
> 
> Fixes: 876133d3161d ("net: hisilicon: add OF dependency")
> Cc: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>

Reviewed-by: Arnd Bergmann <arnd@arndb.de>

Thanks for the fix.

Rob/Frank, any chance we get this into -rc1 through your tree?

The background is that a bugfix I did for a network driver started
causing the build error on sparc allmodconfig, and it would be nice
to have 4.4-rc1 build fine without having to back out my fix.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] of: Provide static inline function for of_translate_address if needed Guenter Roeck <linux@roeck-us.net> - 2015-11-07 04:30 +0100
  Re: [PATCH] of: Provide static inline function for of_translate_address if needed Arnd Bergmann <arnd@arndb.de> - 2015-11-07 10:10 +0100

csiph-web