Re: [PATCH] lustre: obdclass: fix sparse warning

From	Greg KH <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] lustre: obdclass: fix sparse warning
Date	2015-11-07 03:50 +0100
Message-ID	<qs1JL-4zz-5@gated-at.bofh.it> (permalink)
References	<qpWuR-5Yl-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Nov 01, 2015 at 02:12:29PM +0530, Paul Davies C wrote:
> Fix the following warning given by sparse:
> 
> drivers/staging/lustre/lustre/obdclass/cl_lock.c:690:5: warning: symbol 'cl_lock_mutex_try' was not declared. Should it be static?
> 
> Signed-off-by: Paul Davies C <pauldaviesc@gmail.com>
> ---
>  drivers/staging/lustre/lustre/obdclass/cl_lock.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/lustre/lustre/obdclass/cl_lock.c b/drivers/staging/lustre/lustre/obdclass/cl_lock.c
> index 5621beb..6f83452 100644
> --- a/drivers/staging/lustre/lustre/obdclass/cl_lock.c
> +++ b/drivers/staging/lustre/lustre/obdclass/cl_lock.c
> @@ -687,7 +687,7 @@ EXPORT_SYMBOL(cl_lock_mutex_get);
>   *
>   * \see cl_lock_mutex_get()
>   */
> -int cl_lock_mutex_try(const struct lu_env *env, struct cl_lock *lock)
> +static int cl_lock_mutex_try(const struct lu_env *env, struct cl_lock *lock)
>  {
>  	int result;
>  

Someone did this before you did, sorry :(
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] lustre: obdclass: fix sparse warning Paul Davies C <pauldaviesc@gmail.com> - 2015-11-01 09:50 +0100
  Re: [PATCH] lustre: obdclass: fix sparse warning Greg KH <gregkh@linuxfoundation.org> - 2015-11-07 03:50 +0100

csiph-web