Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1264705

Re: [lustre-devel] [PATCH 07/10] staging: lustre: Handle nodemask on UMP machines

From Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups linux.kernel
Subject Re: [lustre-devel] [PATCH 07/10] staging: lustre: Handle nodemask on UMP machines
Date 2015-11-07 03:50 +0100
Message-ID <qs1JL-4zz-3@gated-at.bofh.it> (permalink)
References <qrbia-47z-41@gated-at.bofh.it> <qrgUx-7M5-1@gated-at.bofh.it> <qrXwu-25P-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Fri, Nov 06, 2015 at 10:18:17PM +0000, Simmons, James A. wrote:
> >All warnings (new ones prefixed by >>):
> >
> >   In file included from include/linux/bitops.h:36:0,
> >                    from drivers/staging/lustre/lustre/libcfs/../../include/linux/libcfs/linux/libcfs.h:44,
> >                    from drivers/staging/lustre/lustre/libcfs/../../include/linux/libcfs/libcfs.h:40,
> >                    from drivers/staging/lustre/lustre/libcfs/libcfs_cpu.c:38:
> >   drivers/staging/lustre/lustre/libcfs/libcfs_cpu.c: In function 'cfs_cpt_table_alloc':
> >>> arch/m68k/include/asm/bitops.h:64:5: warning: passing argument 2 of 'bset_mem_set_bit' from incompatible pointer type
> >        bset_mem_set_bit(nr, vaddr) : \
> >        ^
> >>> drivers/staging/lustre/lustre/libcfs/libcfs_cpu.c:61:3: note: in expansion of macro 'set_bit'
> >      set_bit(0, &cptab->ctb_nodemask);
> 
> Yep and additional patch exist to fix this. Should I just push the fix for this or drop this patch and create
> a new patch that is combo of both fixes.
> 
> BTW Greg this new batch of patches are order independent. Sorry for not pointing that out. The rest of the
> patch appear to be okay.

Ok, I'll drop this one, and apply the rest, please resend this after you
have fixed it up.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 01/10] staging: lustre: wrong parameter to cfs_hash_keycpy James Simmons <jsimmons@infradead.org> - 2015-11-04 19:50 +0100
  [PATCH 07/10] staging: lustre: Handle nodemask on UMP machines James Simmons <jsimmons@infradead.org> - 2015-11-04 19:50 +0100
    RE: [lustre-devel] [PATCH 07/10] staging: lustre: Handle nodemask on  UMP machines "Simmons, James A." <simmonsja@ornl.gov> - 2015-11-06 23:20 +0100
      Re: [lustre-devel] [PATCH 07/10] staging: lustre: Handle nodemask on  UMP machines Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-11-07 03:50 +0100
      Re: [lustre-devel] [PATCH 07/10] staging: lustre: Handle nodemask on  UMP machines Dan Carpenter <dan.carpenter@oracle.com> - 2015-11-07 22:00 +0100
  [PATCH 09/10] staging: lustre: remove page_collection::pc_lock in libcfs James Simmons <jsimmons@infradead.org> - 2015-11-04 19:50 +0100

csiph-web