Re: [PATCH 04/10] pwm: core: use bitops

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 04/10] pwm: core: use bitops
Date	Fri, 06 Nov 2015 22:40:02 +0100
Message-ID	<qrWTM-1C2-9@gated-at.bofh.it> (permalink)
References	<qnXEJ-4YZ-3@gated-at.bofh.it> <qnXEL-4YZ-33@gated-at.bofh.it> <qrQuZ-5Lv-5@gated-at.bofh.it> <qrQuZ-5Lv-9@gated-at.bofh.it>
X-Original-To	Olliver Schinagl <o.schinagl@ultimaker.com>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=vzZMMqJFGuBsYNrOy/vUro4PVew5e76KfTRrQj5OCig=; b=vEEU29wtPpF77FdMCfbQmV63xjZ4PbzTJF7aEECAQO2IKlor+DJ8yhzMAIq2qKII4R L5DCWbaOIGXPsXRAysBUCOcVfN9zF1nbn1pXmkME/4OZ7I9IvWiHx2UnuMBRuNG/hQf1 gvwuu05woDixXswle10TBk7JMf7oRNUseyhMhNBi1yZVP+avbUbigRtwplodJCtlUY0R HKkWjFIbHJAAHbWoMV/Vymc1DActkfQT0PtXKsamgWCoiVVf/zODYj2UQlkGMKgbwFxS J54zOAd52YcM7XMsPJ8UUrCaTCFtpLY195vAXfz31nLWagQf+S4R5pBcdnrpuGZQwnD1 p3rg==
MIME-Version	1.0
X-Received	by 10.129.133.5 with SMTP id v5mr12025670ywf.169.1446845804969; Fri, 06 Nov 2015 13:36:44 -0800 (PST)
Content-Type	text/plain; charset=UTF-8
Content-Transfer-Encoding	8BIT
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	64
Organization	linux.* mail to news gateway
X-Original-Cc	Thierry Reding <thierry.reding@gmail.com>, Olliver Schinagl <oliver@schinagl.nl>, Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>, Ian Campbell <ijc+devicetree@hellion.org.uk>, Kumar Gala <galak@codeaurora.org>, Joachim Eastwood <manabian@gmail.com>, Maxime Ripard <maxime.ripard@free-electrons.com>, Alexandre Belloni <alexandre.belloni@free-electrons.com>, Olliver Schinagl <oliver+list@schinagl.nl>, linux-pwm@vger.kernel.org, devicetree <devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>
X-Original-Date	Fri, 6 Nov 2015 23:36:44 +0200
X-Original-Message-ID	<CAHp75VdCoM5ZtMhwt8emC8GtFEuguEXYWZCJgT4hTBcMA7yQ-A@mail.gmail.com>
X-Original-References	<1445895161-2317-1-git-send-email-o.schinagl@ultimaker.com> <1445895161-2317-5-git-send-email-o.schinagl@ultimaker.com> <20151106144635.GA8418@ulmo> <563CBDF5.50904@ultimaker.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1264578

Show key headers only | View raw

On Fri, Nov 6, 2015 at 4:49 PM, Olliver Schinagl
<o.schinagl@ultimaker.com> wrote:
> Hey Thierry,
>
> but why have the bit macro at all then :)

For my opinion, it's good to use in new code, or when you have this
change as a continuation of bigger series.
Though, others might have a different one :-)

>
> But that choice I guess I leave to you, as it's your section, I know some
> submaintainers prefer it and want it to be used, so I guess it's something
> in general kernel wide that should be desided on, BIT() macro preferred or
> not.
>
> Olliver
>
>
> On 06-11-15 15:46, Thierry Reding wrote:
>>
>> On Mon, Oct 26, 2015 at 10:32:35PM +0100, Olliver Schinagl wrote:
>>>
>>> From: Olliver Schinagl <oliver@schinagl.nl>
>>>
>>> The pwm header defines bits manually while there is a nice bitops.h with
>>> a BIT() macro. Use the BIT() macro to set bits in pwm.h
>>>
>>> Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>
>>> ---
>>>   include/linux/pwm.h | 7 ++++---
>>>   1 file changed, 4 insertions(+), 3 deletions(-)
>>
>> I don't think this is a useful change. The BIT() macro needs the same
>> number of characters to type at the expense of requiring an additional
>> include.
>>
>> Thierry
>
>
> --
> Met vriendelijke groeten, Kind regards, 与亲切的问候
>
> Olliver Schinagl
> Software Engineer
> Research & Development
> Ultimaker B.V.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/



-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 04/10] pwm: core: use bitops Thierry Reding <thierry.reding@gmail.com> - 2015-11-06 15:50 +0100
  Re: [PATCH 04/10] pwm: core: use bitops Olliver Schinagl <o.schinagl@ultimaker.com> - 2015-11-06 15:50 +0100
    Re: [PATCH 04/10] pwm: core: use bitops Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-11-06 22:40 +0100

csiph-web