Re: [PATCH 04/10] pwm: core: use bitops

From	Thierry Reding <thierry.reding@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 04/10] pwm: core: use bitops
Date	2015-11-06 15:50 +0100
Message-ID	<qrQuZ-5Lv-5@gated-at.bofh.it> (permalink)
References	<qnXEJ-4YZ-3@gated-at.bofh.it> <qnXEL-4YZ-33@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Mon, Oct 26, 2015 at 10:32:35PM +0100, Olliver Schinagl wrote:
> From: Olliver Schinagl <oliver@schinagl.nl>
> 
> The pwm header defines bits manually while there is a nice bitops.h with
> a BIT() macro. Use the BIT() macro to set bits in pwm.h
> 
> Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>
> ---
>  include/linux/pwm.h | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)

I don't think this is a useful change. The BIT() macro needs the same
number of characters to type at the expense of requiring an additional
include.

Thierry

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 04/10] pwm: core: use bitops Thierry Reding <thierry.reding@gmail.com> - 2015-11-06 15:50 +0100
  Re: [PATCH 04/10] pwm: core: use bitops Olliver Schinagl <o.schinagl@ultimaker.com> - 2015-11-06 15:50 +0100
    Re: [PATCH 04/10] pwm: core: use bitops Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-11-06 22:40 +0100

csiph-web