Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1263643

Re: [PATCH v2 1/2] arm64: dts: exynos7: Add pmic s2mps15 device tree node

Show all headers | View raw

On 05.11.2015 20:52, Alim Akhtar wrote:
> This patch add pmic (s2mps15) node of espresso board,
> which includes addition of regulators and pmic-clk sub-nodes.

My comment for fixing capital letters was ignored. Do you disagree with it?

> 
> This patch also adds {vmmc,vqmmc}-supply properties for mmc2 node.
> 
> Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
> Changes since v1:
> * Addressed Javier and Krzysztof review comments.
> * Removed unused ldo/buck nodes.
> * Removed always-on properties from ldo/buck to disable them
> * Added a consumer of pmic supply (like mmc)
> 
>  arch/arm64/boot/dts/exynos/exynos7-espresso.dts |  280 +++++++++++++++++++++++
>  1 file changed, 280 insertions(+)
> 

Rest looks good, so with the fix above:

Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Best regards,
Krzysztof

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/2] arm64: dts: exynos7: Add pmic s2mps15 device tree node Alim Akhtar <alim.akhtar@samsung.com> - 2015-11-05 13:00 +0100
  Re: [PATCH v2 1/2] arm64: dts: exynos7: Add pmic s2mps15 device tree  node Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-11-06 01:00 +0100
    Re: [PATCH v2 1/2] arm64: dts: exynos7: Add pmic s2mps15 device tree node Alim Akhtar <alim.akhtar@gmail.com> - 2015-11-06 01:30 +0100

csiph-web