Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1260446
| From | Daniel Lezcano <daniel.lezcano@linaro.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 5/7] clocksource/drivers/pxa_timer: Move the Kconfig rule |
| Date | 2015-11-02 09:10 +0100 |
| Message-ID | <qqilI-2Ut-9@gated-at.bofh.it> (permalink) |
| References | <qqi2m-2yF-25@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi Amit, On 11/02/2015 08:44 AM, Amit Kucheria wrote: > On Fri, Oct 30, 2015 at 4:22 AM, Daniel Lezcano > <daniel.lezcano@linaro.org> wrote: >> Instead of having the clocksource's Kconfig depending on the arch, let the >> arch to select the timer it needs. > > Is this the prescribed way to do things nowadays? It leads to more > options showing up in 'make menuconfig'. Why do I need to see > CLKSRC_PXA if I'm not even compiling for ARCH_PXA (and not interesting > in COMPILE_TEST)? That won't happen. As the 'bool' has no string after, it won't show up in the menuconfig. Actually, with the next patch, only COMPILE_TEST will show it up in the Device Drivers->Clocksource drivers. >> The CLKSRC_OF dependency is removed because already selected by the ARCH_PXA, >> and it is added for SA1100. > > This bit makes sense. > >> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> >> --- >> arch/arm/Kconfig | 3 +++ >> drivers/clocksource/Kconfig | 3 +-- >> 2 files changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig >> index 72ad724..aa32286 100644 >> --- a/arch/arm/Kconfig >> +++ b/arch/arm/Kconfig >> @@ -609,6 +609,7 @@ config ARCH_PXA >> select AUTO_ZRELADDR >> select COMMON_CLK >> select CLKDEV_LOOKUP >> + select CLKSRC_PXA >> select CLKSRC_MMIO >> select CLKSRC_OF >> select GENERIC_CLOCKEVENTS >> @@ -669,6 +670,8 @@ config ARCH_SA1100 >> select ARCH_SPARSEMEM_ENABLE >> select CLKDEV_LOOKUP >> select CLKSRC_MMIO >> + select CLKSRC_PXA >> + select CLKSRC_OF if OF >> select CPU_FREQ >> select CPU_SA1100 >> select GENERIC_CLOCKEVENTS >> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig >> index 5cd000c..425abbd 100644 >> --- a/drivers/clocksource/Kconfig >> +++ b/drivers/clocksource/Kconfig >> @@ -289,8 +289,7 @@ config CLKSRC_TANGO_XTAL >> select CLKSRC_OF >> >> config CLKSRC_PXA >> - def_bool y if ARCH_PXA || ARCH_SA1100 >> - select CLKSRC_OF if OF >> + bool -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH 5/7] clocksource/drivers/pxa_timer: Move the Kconfig rule Amit Kucheria <amit.kucheria@verdurent.com> - 2015-11-02 08:50 +0100
Re: [PATCH 5/7] clocksource/drivers/pxa_timer: Move the Kconfig rule Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 09:10 +0100
Re: [PATCH 5/7] clocksource/drivers/pxa_timer: Move the Kconfig rule Amit Kucheria <amit.kucheria@verdurent.com> - 2015-11-02 11:20 +0100
csiph-web