Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1260447
| From | Namhyung Kim <namhyung@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v11 12/28] tracing: Add hist trigger support for user-defined sorting ('sort=' param) |
| Date | 2015-11-02 09:10 +0100 |
| Message-ID | <qqilI-2Ut-15@gated-at.bofh.it> (permalink) |
| References | <qmsD0-1Xu-7@gated-at.bofh.it> <qmsD2-1Xu-59@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, Oct 22, 2015 at 01:14:16PM -0500, Tom Zanussi wrote:
> Allow users to specify keys and/or values to sort on. With this
> addition, keys and values specified using the 'keys=' and 'vals='
> keywords can be used to sort the hist trigger output via a new 'sort='
> keyword. If multiple sort keys are specified, the output will be
> sorted using the second key as a secondary sort key, etc. The default
> sort order is ascending; if the user wants a different sort order,
> '.descending' can be appended to the specific sort key. Before this
> addition, output was always sorted by 'hitcount' in ascending order.
>
> This expands the hist trigger syntax from this:
>
> # echo hist:keys=xxx:vals=yyy \
> [ if filter] > event/trigger
>
> to this:
>
> # echo hist:keys=xxx:vals=yyy:sort=zzz.descending \
> [ if filter] > event/trigger
>
> Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com>
> Tested-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
> ---
[SNIP]
> static int create_sort_keys(struct hist_trigger_data *hist_data)
> {
> + char *fields_str = hist_data->attrs->sort_key_str;
> + struct ftrace_event_field *field = NULL;
> + struct tracing_map_sort_key *sort_key;
> + unsigned int i, j;
> int ret = 0;
>
> hist_data->n_sort_keys = 1; /* sort_keys[0] is always hitcount */
This comment should be updated.
Thanks,
Namhyung
>
> + if (!fields_str)
> + goto out;
> +
> + strsep(&fields_str, "=");
> + if (!fields_str) {
> + ret = -EINVAL;
> + goto out;
> + }
> +
> + for (i = 0; i < TRACING_MAP_SORT_KEYS_MAX; i++) {
> + char *field_str, *field_name;
> +
> + sort_key = &hist_data->sort_keys[i];
> +
> + field_str = strsep(&fields_str, ",");
> + if (!field_str) {
> + if (i == 0)
> + ret = -EINVAL;
> + break;
> + }
> +
> + if ((i == TRACING_MAP_SORT_KEYS_MAX - 1) && fields_str) {
> + ret = -EINVAL;
> + break;
> + }
> +
> + field_name = strsep(&field_str, ".");
> + if (!field_name) {
> + ret = -EINVAL;
> + break;
> + }
> +
> + if (!strcmp(field_name, "hitcount")) {
> + ret = is_descending(field_str);
> + if (ret < 0)
> + break;
> + sort_key->descending = ret;
> + continue;
> + }
> +
> + for (j = 1; j < hist_data->n_fields; j++) {
> + field = hist_data->fields[j]->field;
> + if (field && !strcmp(field_name, field->name)) {
> + sort_key->field_idx = j;
> + ret = is_descending(field_str);
> + if (ret < 0)
> + goto out;
> + sort_key->descending = ret;
> + break;
> + }
> + }
> + if (j == hist_data->n_fields) {
> + ret = -EINVAL;
> + break;
> + }
> + }
> + hist_data->n_sort_keys = i;
> + out:
> return ret;
> }
>
> @@ -737,7 +817,26 @@ static int event_hist_trigger_print(struct seq_file *m,
> }
>
> seq_puts(m, ":sort=");
> - seq_puts(m, "hitcount");
> +
> + for (i = 0; i < hist_data->n_sort_keys; i++) {
> + struct tracing_map_sort_key *sort_key;
> +
> + sort_key = &hist_data->sort_keys[i];
> +
> + if (i > 0)
> + seq_puts(m, ",");
> +
> + if (sort_key->field_idx == HITCOUNT_IDX)
> + seq_puts(m, "hitcount");
> + else {
> + unsigned int idx = sort_key->field_idx;
> +
> + hist_field_print(m, hist_data->fields[idx]);
> + }
> +
> + if (sort_key->descending)
> + seq_puts(m, ".descending");
> + }
>
> seq_printf(m, ":size=%u", (1 << hist_data->map->map_bits));
>
> --
> 1.9.3
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 00/28] tracing: 'hist' triggers Tom Zanussi <tom.zanussi@linux.intel.com> - 2015-10-22 20:20 +0200
[PATCH v11 16/28] tracing: Add hist trigger 'sym' and 'sym-offset' modifiers Tom Zanussi <tom.zanussi@linux.intel.com> - 2015-10-22 20:20 +0200
[PATCH v11 12/28] tracing: Add hist trigger support for user-defined sorting ('sort=' param) Tom Zanussi <tom.zanussi@linux.intel.com> - 2015-10-22 20:20 +0200
Re: [PATCH v11 12/28] tracing: Add hist trigger support for user-defined sorting ('sort=' param) Namhyung Kim <namhyung@kernel.org> - 2015-11-02 09:10 +0100
[PATCH v11 01/28] tracing: Update cond flag when enabling or disabling a trigger Tom Zanussi <tom.zanussi@linux.intel.com> - 2015-10-22 20:30 +0200
[PATCH v11 27/28] kselftests/ftrace : Add event trigger testcases Tom Zanussi <tom.zanussi@linux.intel.com> - 2015-10-22 20:30 +0200
[PATCH v11 10/28] tracing: Add hist trigger support for multiple values ('vals=' param) Tom Zanussi <tom.zanussi@linux.intel.com> - 2015-10-22 20:30 +0200
Re: [PATCH v11 10/28] tracing: Add hist trigger support for multiple values ('vals=' param) Namhyung Kim <namhyung@kernel.org> - 2015-11-02 08:50 +0100
[PATCH v11 06/28] tracing: Add a per-event-trigger 'paused' field Tom Zanussi <tom.zanussi@linux.intel.com> - 2015-10-22 20:30 +0200
[PATCH v11 25/28] tracing: Add support for named triggers Tom Zanussi <tom.zanussi@linux.intel.com> - 2015-10-22 20:30 +0200
[PATCH v11 18/28] tracing: Add hist trigger 'syscall' modifier Tom Zanussi <tom.zanussi@linux.intel.com> - 2015-10-22 20:30 +0200
[PATCH v11 03/28] tracing: Make event trigger functions available Tom Zanussi <tom.zanussi@linux.intel.com> - 2015-10-22 20:30 +0200
[PATCH v11 04/28] tracing: Add event record param to trigger_ops.func() Tom Zanussi <tom.zanussi@linux.intel.com> - 2015-10-22 20:30 +0200
Re: [PATCH 00/28] tracing: 'hist' triggers Steven Rostedt <rostedt@goodmis.org> - 2015-10-22 20:30 +0200
Re: [PATCH 00/28] tracing: 'hist' triggers Tom Zanussi <tom.zanussi@linux.intel.com> - 2015-10-22 20:40 +0200
[PATCH v11 05/28] tracing: Add get_syscall_name() Tom Zanussi <tom.zanussi@linux.intel.com> - 2015-10-22 20:30 +0200
Re: [PATCH v11 08/28] tracing: Add lock-free tracing_map Namhyung Kim <namhyung@kernel.org> - 2015-10-29 09:40 +0100
Re: [PATCH v11 08/28] tracing: Add lock-free tracing_map Tom Zanussi <tom.zanussi@linux.intel.com> - 2015-10-29 19:40 +0100
Re: [PATCH v11 08/28] tracing: Add lock-free tracing_map Namhyung Kim <namhyung@kernel.org> - 2015-11-02 08:10 +0100
Re: [PATCH v11 08/28] tracing: Add lock-free tracing_map Tom Zanussi <tom.zanussi@linux.intel.com> - 2015-11-04 02:50 +0100
Re: [PATCH v11 08/28] tracing: Add lock-free tracing_map Namhyung Kim <namhyung@kernel.org> - 2015-11-04 03:30 +0100
Re: [PATCH v11 08/28] tracing: Add lock-free tracing_map Tom Zanussi <tom.zanussi@linux.intel.com> - 2015-11-04 04:00 +0100
Re: [PATCH 00/28] tracing: 'hist' triggers Namhyung Kim <namhyung@kernel.org> - 2015-11-05 15:50 +0100
RE: [PATCH 00/28] tracing: 'hist' triggers 平松雅巳 / HIRAMATU，MASAMI <masami.hiramatsu.pt@hitachi.com> - 2015-11-05 16:00 +0100
Re: [PATCH 00/28] tracing: 'hist' triggers Tom Zanussi <tom.zanussi@linux.intel.com> - 2015-11-05 23:20 +0100
Re: [PATCH 00/28] tracing: 'hist' triggers Namhyung Kim <namhyung@kernel.org> - 2015-11-06 00:20 +0100
csiph-web