Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1260259

Re: [lustre-devel] [PATCH 1/3] staging: lustre: checkpatch cleanups for nidstring.c

Show all headers | View raw

I suspect you're over-thinking it.  The maintainers appear to be
reacting to the different types of style changes - "checkpatch
cleanups" is an awfully broad commit message.  I'd suggest breaking
this patch (and any others like it) into two pieces; one with
whitespace cleanups, and one with the "== NULL" fixes (and mentioning
both by kind in the commit message, rather than just attributing to
checkpatch).  Then issue a v2 of the series, and see where you land.

Of course, YMMV. :-)

--
Mike Shuey


On Sun, Nov 1, 2015 at 6:07 PM, Simmons, James A. <simmonsja@ornl.gov> wrote:
>>On Thu, Oct 29, 2015 at 07:28:21PM -0400, James Simmons wrote:
>>> With nidstring now having the latest fixes we can
>>> now clean up all the remaining checkpatch errors
>>> for nidstring.c.
>>
>>Please be specific as to exactly what you changed, and break it up into
>>one-patch-per-thing.  And no, "fix all checkpatch errors" is not "one
>>thing"
>
> Hmm. This makes me think I might be going about this wrong.  Instead of
> doing style changes per file I should be doing one style change per subsystem
> instead. Unless you prefer doing these style changes on per file base. Perhaps
> for now I should focus on pushing the fixes that have cumulated and once
> caught up then finished off the style issues.
> _______________________________________________
> lustre-devel mailing list
> lustre-devel@lists.lustre.org
> http://lists.lustre.org/listinfo.cgi/lustre-devel-lustre.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] make nidstring.c kernel style compliant James Simmons <jsimmons@infradead.org> - 2015-10-30 00:30 +0100
  [PATCH 2/3] staging: lustre: white space cleanups for nidstring.c James Simmons <jsimmons@infradead.org> - 2015-10-30 00:30 +0100
  [PATCH 1/3] staging: lustre: checkpatch cleanups for nidstring.c James Simmons <jsimmons@infradead.org> - 2015-10-30 00:30 +0100
    Re: [PATCH 1/3] staging: lustre: checkpatch cleanups for nidstring.c Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-10-30 09:00 +0100
    Re: [PATCH 1/3] staging: lustre: checkpatch cleanups for nidstring.c Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-10-31 00:10 +0100
      RE: [lustre-devel] [PATCH 1/3] staging: lustre: checkpatch cleanups  for nidstring.c "Simmons, James A." <simmonsja@ornl.gov> - 2015-11-02 00:10 +0100
        Re: [lustre-devel] [PATCH 1/3] staging: lustre: checkpatch cleanups  for nidstring.c Michael Shuey <shuey@purdue.edu> - 2015-11-02 00:30 +0100
        Re: [lustre-devel] [PATCH 1/3] staging: lustre: checkpatch cleanups  for nidstring.c Dan Carpenter <dan.carpenter@oracle.com> - 2015-11-02 15:50 +0100
          RE: [lustre-devel] [PATCH 1/3] staging: lustre: checkpatch cleanups  for nidstring.c "Simmons, James A." <simmonsja@ornl.gov> - 2015-11-04 01:00 +0100

csiph-web