Groups > linux.kernel > #1261976

RE: [lustre-devel] [PATCH 1/3] staging: lustre: checkpatch cleanups for nidstring.c

From	"Simmons, James A." <simmonsja@ornl.gov>
Newsgroups	linux.kernel
Subject	RE: [lustre-devel] [PATCH 1/3] staging: lustre: checkpatch cleanups for nidstring.c
Date	2015-11-04 01:00 +0100
Message-ID	<qqTEC-171-11@gated-at.bofh.it> (permalink)
References	<qp4NQ-6FS-7@gated-at.bofh.it> <qp4NQ-6FS-19@gated-at.bofh.it> <qpqY2-3ym-3@gated-at.bofh.it> <qq9V7-65A-1@gated-at.bofh.it> <qqoAN-6vo-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

>Yeah.  That is often the fastest way to fix all the checkpatch warnings.
>
>Checkpatch warnings are pretty mechanical.  Just send like 100 patches
>at a time until everything is fixed.  Don't overthink.  Say your patch
>breaks the alignment then you have to fix that, but otherwise only fix
>one thing at a time.  Sometimes people will ask you to fix something
>else on the same line, but just say "I didn't introduce that, but yes I
>am planning to fix that in a later patchset since I am following the
>one thing per patch rule."
>
>Don't feel shame about sending many small patches.  We pretty much merge
>everything.

It was the sense of it taking forever with that amount of patches needed with
the one file approach. Looking at the back log of fixes its not as bad as I thought
for libcfs/LNet. Once those fixes are merged the style cleanups can happen
pretty quickly.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

RE: [lustre-devel] [PATCH 1/3] staging: lustre: checkpatch cleanups  for nidstring.c "Simmons, James A." <simmonsja@ornl.gov> - 2015-11-02 00:10 +0100
  Re: [lustre-devel] [PATCH 1/3] staging: lustre: checkpatch cleanups  for nidstring.c Michael Shuey <shuey@purdue.edu> - 2015-11-02 00:30 +0100
  Re: [lustre-devel] [PATCH 1/3] staging: lustre: checkpatch cleanups  for nidstring.c Dan Carpenter <dan.carpenter@oracle.com> - 2015-11-02 15:50 +0100
    RE: [lustre-devel] [PATCH 1/3] staging: lustre: checkpatch cleanups  for nidstring.c "Simmons, James A." <simmonsja@ornl.gov> - 2015-11-04 01:00 +0100

csiph-web