Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1262022
| Path | csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Samuel Ortiz <sameo@linux.intel.com> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] NFC: nfcmrvl: fix SPI driver dependencies |
| Date | Wed, 04 Nov 2015 02:40:02 +0100 |
| Message-ID | <qqVdo-2aG-9@gated-at.bofh.it> (permalink) |
| References | <qqKrF-3Jf-29@gated-at.bofh.it> |
| X-Original-To | Arnd Bergmann <arnd@arndb.de> |
| X-Extloop1 | 1 |
| X-Ironport-Av | E=Sophos;i="5.20,240,1444719600"; d="scan'208";a="593573332" |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=us-ascii |
| Content-Disposition | inline |
| User-Agent | Mutt/1.5.24 (2015-08-30) |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 27 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Vincent Cuissard <cuissard@marvell.com>, Lauro Ramos Venancio <lauro.venancio@openbossa.org>, Aloisio Almeida Jr <aloisio.almeida@openbossa.org>, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org |
| X-Original-Date | Wed, 4 Nov 2015 02:37:14 +0100 |
| X-Original-Message-ID | <20151104013714.GA4090@zurbaran.home> |
| X-Original-References | <243350307.K4hHIg3V2N@wuerfel> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1262022 |
Show key headers only | View raw
Hi Arnd,
On Tue, Nov 03, 2015 at 03:03:33PM +0100, Arnd Bergmann wrote:
> The newly added nfcmrvl_spi driver uses the spi_nci
> infrastructure, but does not have a Kconfig dependency on
> that, so we can get a link-time error:
>
> drivers/built-in.o: In function `nfcmrvl_spi_nci_send':
> (.text+0x1428dc): undefined reference to `nci_spi_send'
> drivers/built-in.o: In function `nfcmrvl_spi_probe':
> (.text+0x142a24): undefined reference to `nci_spi_allocate_spi'
> drivers/built-in.o: In function `nfcmrvl_spi_int_irq_thread_fn':
> (.text+0x142abc): undefined reference to `nci_spi_read'
>
> This clarifies the dependency.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: caf6e49bf6d0 ("NFC: nfcmrvl: add spi driver")
Applied, thanks.
Cheers,
Samuel.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH] NFC: nfcmrvl: fix SPI driver dependencies Arnd Bergmann <arnd@arndb.de> - 2015-11-03 15:10 +0100 Re: [PATCH] NFC: nfcmrvl: fix SPI driver dependencies Samuel Ortiz <sameo@linux.intel.com> - 2015-11-04 02:40 +0100
csiph-web