Re: [PATCH] ssb: mark ssb_bus_register as __maybe_unused

From	Michael Büsch <m@bues.ch>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ssb: mark ssb_bus_register as __maybe_unused
Date	2015-11-03 18:00 +0100
Message-ID	<qqN6a-5mL-3@gated-at.bofh.it> (permalink)
References	<qqLxp-4or-31@gated-at.bofh.it> <qqMD8-5cu-9@gated-at.bofh.it> <qqMWu-5jl-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Tue, 03 Nov 2015 17:42:26 +0100
Arnd Bergmann <arnd@arndb.de> wrote:

> On Tuesday 03 November 2015 17:27:21 Michael Büsch wrote:
> > On Tue, 03 Nov 2015 16:05:51 +0100
> > Arnd Bergmann <arnd@arndb.de> wrote:
> >   
> > > The SoC variant of the ssb code is now optional like the other
> > > ones, which means we can build the framwork without any
> > > front-end, but that results in a warning:
> > > 
> > > drivers/ssb/main.c:616:12: warning: 'ssb_bus_register' defined but not used [-Wunused-function]
> > > 
> > > This annotates the ssb_bus_register function as __maybe_unused to
> > > shut up the warning. A configuration like this will not work on
> > > any hardware of course, but we still want this to silently build
> > > without warnings if the configuration is allowed in the first
> > > place.  
> > 
> > 
> > Is there a simple way to disallow this configuration?  
> 
> I could not come up with a simple one. We could turn 'CONFIG_SSB' into
> a silent option and have it selected by each bus specific driver,
> but then we also have to change all the device drivers (usb and
> wireless I guess) to use 'depends on' rather than 'select'.

The other way around?
The drivers already select SSB. However I think we should have SSB
selectable by user for the embedded case.

But well, I can live with this patch then. Kalle, you might apply it
with

Acked-by: Michael Buesch <m@bues.ch>

-- 
Michael

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ssb: mark ssb_bus_register as __maybe_unused Arnd Bergmann <arnd@arndb.de> - 2015-11-03 16:20 +0100
  [PATCH] ARM: at91/defconfig: remove CONFIG_SSB from Atmel defconfigs Nicolas Ferre <nicolas.ferre@atmel.com> - 2015-11-03 17:00 +0100
  Re: [PATCH] ssb: mark ssb_bus_register as __maybe_unused Michael Büsch <m@bues.ch> - 2015-11-03 17:30 +0100
    Re: [PATCH] ssb: mark ssb_bus_register as __maybe_unused Arnd Bergmann <arnd@arndb.de> - 2015-11-03 17:50 +0100
      Re: [PATCH] ssb: mark ssb_bus_register as __maybe_unused Michael Büsch <m@bues.ch> - 2015-11-03 18:00 +0100

csiph-web