Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1261560

Re: [PATCH V4] usb: remove unnecessary CONFIG_PM dependency from USB_OTG

Show all headers | View raw

On Tue, Nov 03, 2015 at 07:56:55AM -0600, Felipe Balbi wrote:
> 
> Hi,
> 
> Nathan Sullivan <nathan.sullivan@ni.com> writes:
> > The USB OTG support currently depends on power management
> > (CONFIG_PM) being enabled, but does not actually need it enabled.
> > Remove this dependency.
> >
> > Tested on Bay Trail hardware with dwc3 USB.
> >
> > Signed-off-by: Nathan Sullivan <nathan.sullivan@ni.com>
> > ---
> >  drivers/usb/core/Kconfig |    1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/usb/core/Kconfig b/drivers/usb/core/Kconfig
> > index a99c89e..9c5cdf3 100644
> > --- a/drivers/usb/core/Kconfig
> > +++ b/drivers/usb/core/Kconfig
> > @@ -43,7 +43,6 @@ config USB_DYNAMIC_MINORS
> >  
> >  config USB_OTG
> >  	bool "OTG support"
> > -	depends on PM
> 
> I don't think this is correct. OTG depends on USB bus suspend, which is
> only available on PM builds. Care to further detail why you think PM is
> not needed on OTG ?
> 
> -- 
> balbi

I think we can drop this patch, actually.

It looks like we confused gadget and OTG support at some point in the past,
and we don't want PM on our hardware for latency reasons.  We really only need
USB gadget support, not full OTG.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH V4] usb: remove unnecessary CONFIG_PM dependency from USB_OTG Felipe Balbi <balbi@ti.com> - 2015-11-03 15:00 +0100
  Re: [PATCH V4] usb: remove unnecessary CONFIG_PM dependency from  USB_OTG Nathan Sullivan <nathan.sullivan@ni.com> - 2015-11-03 16:00 +0100
    Re: [PATCH V4] usb: remove unnecessary CONFIG_PM dependency from USB_OTG Felipe Balbi <balbi@ti.com> - 2015-11-03 16:10 +0100
  Re: [PATCH V4] usb: remove unnecessary CONFIG_PM dependency from USB_OTG Felipe Balbi <balbi@ti.com> - 2015-11-04 05:00 +0100
    Re: [PATCH V4] usb: remove unnecessary CONFIG_PM dependency from USB_OTG Felipe Balbi <balbi@ti.com> - 2015-11-05 15:40 +0100

csiph-web