Re: [PATCH V4] usb: remove unnecessary CONFIG_PM dependency from USB_OTG

From	Felipe Balbi <balbi@ti.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH V4] usb: remove unnecessary CONFIG_PM dependency from USB_OTG
Date	2015-11-03 15:00 +0100
Message-ID	<qqKhX-3qa-5@gated-at.bofh.it> (permalink)
References	<qoVUe-RM-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

Nathan Sullivan <nathan.sullivan@ni.com> writes:
> The USB OTG support currently depends on power management
> (CONFIG_PM) being enabled, but does not actually need it enabled.
> Remove this dependency.
>
> Tested on Bay Trail hardware with dwc3 USB.
>
> Signed-off-by: Nathan Sullivan <nathan.sullivan@ni.com>
> ---
>  drivers/usb/core/Kconfig |    1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/core/Kconfig b/drivers/usb/core/Kconfig
> index a99c89e..9c5cdf3 100644
> --- a/drivers/usb/core/Kconfig
> +++ b/drivers/usb/core/Kconfig
> @@ -43,7 +43,6 @@ config USB_DYNAMIC_MINORS
>  
>  config USB_OTG
>  	bool "OTG support"
> -	depends on PM

I don't think this is correct. OTG depends on USB bus suspend, which is
only available on PM builds. Care to further detail why you think PM is
not needed on OTG ?

-- 
balbi

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH V4] usb: remove unnecessary CONFIG_PM dependency from USB_OTG Felipe Balbi <balbi@ti.com> - 2015-11-03 15:00 +0100
  Re: [PATCH V4] usb: remove unnecessary CONFIG_PM dependency from  USB_OTG Nathan Sullivan <nathan.sullivan@ni.com> - 2015-11-03 16:00 +0100
    Re: [PATCH V4] usb: remove unnecessary CONFIG_PM dependency from USB_OTG Felipe Balbi <balbi@ti.com> - 2015-11-03 16:10 +0100
  Re: [PATCH V4] usb: remove unnecessary CONFIG_PM dependency from USB_OTG Felipe Balbi <balbi@ti.com> - 2015-11-04 05:00 +0100
    Re: [PATCH V4] usb: remove unnecessary CONFIG_PM dependency from USB_OTG Felipe Balbi <balbi@ti.com> - 2015-11-05 15:40 +0100

csiph-web