Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1260242

Re: [PATCH v6] isdn: Use ktime_t instead of 'struct timeval'

Show all headers | View raw

From: Tina Ruchandani <ruchandani.tina@gmail.com>
Date: Thu, 29 Oct 2015 21:08:16 -0700

> @@ -45,7 +46,7 @@ static u_int *debug;
>  static LIST_HEAD(iclock_list);
>  static DEFINE_RWLOCK(iclock_lock);
>  static u16 iclock_count;		/* counter of last clock */
> -static struct timeval iclock_tv;	/* time stamp of last clock */
> +static ktime_t iclock_tv;		/* time stamp of last clock */
>  static int iclock_tv_valid;		/* already received one timestamp */

It only makes sense for this variable to be named "iclock_tv" when
it is of type "timeval".  And therefore it is confusing to keep
using this variable name after changing it's type to "ktime_t".

Therefore please adjust the variable name appropriately, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v6] isdn: Use ktime_t instead of 'struct timeval' Tina Ruchandani <ruchandani.tina@gmail.com> - 2015-10-30 05:10 +0100
  Re: [PATCH v6] isdn: Use ktime_t instead of 'struct timeval' David Miller <davem@davemloft.net> - 2015-11-01 22:20 +0100
    Re: [PATCH v6] isdn: Use ktime_t instead of 'struct timeval' Tina Ruchandani <ruchandani.tina@gmail.com> - 2015-11-02 08:30 +0100

csiph-web