Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1259861

Re: [PATCH v2] fs/block_dev.c: Remove WARN_ON() when inode writeback fails

From Jens Axboe <axboe@kernel.dk>
Newsgroups linux.kernel
Subject Re: [PATCH v2] fs/block_dev.c: Remove WARN_ON() when inode writeback fails
Date 2015-10-31 00:50 +0100
Message-ID <qprAJ-3Lv-3@gated-at.bofh.it> (permalink)
References <qpjWz-7ym-29@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 10/30/2015 09:34 AM, Jeff Moyer wrote:
> From: Vivek Goyal <vgoyal@redhat.com>
>
> If a block device is hot removed and later last reference to device
> is put, we try to writeback the dirty inode. But device is gone and
> that writeback fails.
>
> Currently we do a WARN_ON() which does not seem to be the right thing.
> Convert it to a ratelimited kernel warning.

Any concerns with putting this into 4.4 and marking it for stable? Would 
be awesome to have a "Fixes:" in here too.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2] fs/block_dev.c: Remove WARN_ON() when inode writeback fails Jeff Moyer <jmoyer@redhat.com> - 2015-10-30 16:40 +0100
  Re: [PATCH v2] fs/block_dev.c: Remove WARN_ON() when inode writeback  fails Jens Axboe <axboe@kernel.dk> - 2015-10-31 00:50 +0100
    Re: [PATCH v2] fs/block_dev.c: Remove WARN_ON() when inode writeback fails Jeff Moyer <jmoyer@redhat.com> - 2015-11-02 16:00 +0100

csiph-web