Re: [PATCH v2] fs/block_dev.c: Remove WARN_ON() when inode writeback fails

From	Jeff Moyer <jmoyer@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] fs/block_dev.c: Remove WARN_ON() when inode writeback fails
Date	2015-11-02 16:00 +0100
Message-ID	<qqoKv-6yI-27@gated-at.bofh.it> (permalink)
References	<qpjWz-7ym-29@gated-at.bofh.it> <qprAJ-3Lv-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Jens Axboe <axboe@kernel.dk> writes:

> On 10/30/2015 09:34 AM, Jeff Moyer wrote:
>> From: Vivek Goyal <vgoyal@redhat.com>
>>
>> If a block device is hot removed and later last reference to device
>> is put, we try to writeback the dirty inode. But device is gone and
>> that writeback fails.
>>
>> Currently we do a WARN_ON() which does not seem to be the right thing.
>> Convert it to a ratelimited kernel warning.
>
> Any concerns with putting this into 4.4 and marking it for stable?

No, that sounds fine to me.

> Would be awesome to have a "Fixes:" in here too.

OK.  I don't know which commit introduced the problem.  Do you want
something like this?

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1196089
or
Fixes: https://www.redhat.com/archives/dm-devel/2015-June/msg00111.html

I know some folks don't like mailing list archive links in the commit
messages.

Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v2] fs/block_dev.c: Remove WARN_ON() when inode writeback fails Jeff Moyer <jmoyer@redhat.com> - 2015-11-02 16:00 +0100

csiph-web