Re: [PATCH v3 net] i40e: Look up MAC address in Open Firmware or IDPROM

From	Sowmini Varadhan <sowmini.varadhan@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 net] i40e: Look up MAC address in Open Firmware or IDPROM
Date	2015-10-31 00:20 +0100
Message-ID	<qpr7H-3BO-7@gated-at.bofh.it> (permalink)
References	(1 earlier) <qpmB4-LN-19@gated-at.bofh.it> <qpmKK-Q6-11@gated-at.bofh.it> <qpn46-WF-29@gated-at.bofh.it> <qpnx7-1mb-7@gated-at.bofh.it> <qpq1Y-2Xs-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On (10/30/15 22:03), Nelson, Shannon wrote:
> The more common idiom in our driver would be
> 
> 	err = i40e_get_platform_mac_addr(..);
> 	if (err) {

Ok.

> Have you tested this beyond a compile?
> Do you have a DT model to try this against?

yes.

> In looking at a couple other drivers, I see the difference being that
> they typically are writing the primary mac filter on probe (and any
> other reset), whereas the i40e "knows" that the default mac address is
> already set up as the filter and doesn't bother with a redundant write.
> If you want to add this Open Filter code, you'll need to arrange for
> this write to happen.  You can't call i40e_set_mac() to do it, but you
> can see the i40e_aq_mac_address_write() code there that is involved in
> updating the mac address as an example.  You probably will want to look
> at section 4.2.1.5.3 of the XL710 data sheet in order to know how to
> use i40e_aq_mac_address_write() for your situation.

ok. I'll look into it (and also why this did not show up in my testing).

fwiw, the ixgbe patch is quite clearly missing in i40e, and hopefully
we wont be opportunistically fixing this one driver at a time in 
the future.

--Sowmini

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH v3 net] i40e: Look up MAC address in Open Firmware or IDPROM Sowmini Varadhan <sowmini.varadhan@oracle.com> - 2015-10-30 16:10 +0100
  Re: [PATCH v3 net] i40e: Look up MAC address in Open Firmware or IDPROM Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-10-30 19:10 +0100
    Re: [PATCH v3 net] i40e: Look up MAC address in Open Firmware or  IDPROM Sowmini Varadhan <sowmini.varadhan@oracle.com> - 2015-10-30 19:20 +0100
      Re: [PATCH v3 net] i40e: Look up MAC address in Open Firmware or IDPROM Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-10-30 19:30 +0100
  RE: [PATCH v3 net] i40e: Look up MAC address in Open Firmware or  IDPROM "Nelson, Shannon" <shannon.nelson@intel.com> - 2015-10-30 19:30 +0100
    Re: [PATCH v3 net] i40e: Look up MAC address in Open Firmware or  IDPROM Sowmini Varadhan <sowmini.varadhan@oracle.com> - 2015-10-30 19:40 +0100
      RE: [PATCH v3 net] i40e: Look up MAC address in Open Firmware or  IDPROM "Nelson, Shannon" <shannon.nelson@intel.com> - 2015-10-30 20:00 +0100
        Re: [PATCH v3 net] i40e: Look up MAC address in Open Firmware or  IDPROM Sowmini Varadhan <sowmini.varadhan@oracle.com> - 2015-10-30 20:30 +0100
          RE: [PATCH v3 net] i40e: Look up MAC address in Open Firmware or  IDPROM "Nelson, Shannon" <shannon.nelson@intel.com> - 2015-10-30 23:10 +0100
            Re: [PATCH v3 net] i40e: Look up MAC address in Open Firmware or  IDPROM Sowmini Varadhan <sowmini.varadhan@oracle.com> - 2015-10-31 00:20 +0100
              Re: [PATCH v3 net] i40e: Look up MAC address in Open Firmware or  IDPROM Sowmini Varadhan <sowmini.varadhan@oracle.com> - 2015-11-01 17:30 +0100
                RE: [PATCH v3 net] i40e: Look up MAC address in Open Firmware or  IDPROM "Nelson, Shannon" <shannon.nelson@intel.com> - 2015-11-01 22:10 +0100

csiph-web