Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1259686
| From | Sowmini Varadhan <sowmini.varadhan@oracle.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3 net] i40e: Look up MAC address in Open Firmware or IDPROM |
| Date | 2015-10-30 19:20 +0100 |
| Message-ID | <qpmro-HX-3@gated-at.bofh.it> (permalink) |
| References | <qpjtw-7np-17@gated-at.bofh.it> <qpmhJ-Ey-27@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On (10/30/15 20:06), Andy Shevchenko wrote:
>
> > +#include "i40e.h"
>
> Why do you need this one exactly?
I needed it to find pf->pdev below.
> > + struct device_node *dp = pci_device_to_OF_node(pf->pdev);
Without it, you will get:
:
CC [M] drivers/net/ethernet/intel/i40e/i40e_common.o
drivers/net/ethernet/intel/i40e/i40e_common.c: In function ?i40e_get_platform_mac_addr?:
drivers/net/ethernet/intel/i40e/i40e_common.c:1021: error: dereferencing pointer to incomplete type
Unless you feel passionately about the \n nits, I'm going to pass on those.
Thanks for reviewing.
--Sowmini
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v3 net] i40e: Look up MAC address in Open Firmware or IDPROM Sowmini Varadhan <sowmini.varadhan@oracle.com> - 2015-10-30 16:10 +0100
Re: [PATCH v3 net] i40e: Look up MAC address in Open Firmware or IDPROM Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-10-30 19:10 +0100
Re: [PATCH v3 net] i40e: Look up MAC address in Open Firmware or IDPROM Sowmini Varadhan <sowmini.varadhan@oracle.com> - 2015-10-30 19:20 +0100
Re: [PATCH v3 net] i40e: Look up MAC address in Open Firmware or IDPROM Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-10-30 19:30 +0100
RE: [PATCH v3 net] i40e: Look up MAC address in Open Firmware or IDPROM "Nelson, Shannon" <shannon.nelson@intel.com> - 2015-10-30 19:30 +0100
Re: [PATCH v3 net] i40e: Look up MAC address in Open Firmware or IDPROM Sowmini Varadhan <sowmini.varadhan@oracle.com> - 2015-10-30 19:40 +0100
RE: [PATCH v3 net] i40e: Look up MAC address in Open Firmware or IDPROM "Nelson, Shannon" <shannon.nelson@intel.com> - 2015-10-30 20:00 +0100
Re: [PATCH v3 net] i40e: Look up MAC address in Open Firmware or IDPROM Sowmini Varadhan <sowmini.varadhan@oracle.com> - 2015-10-30 20:30 +0100
RE: [PATCH v3 net] i40e: Look up MAC address in Open Firmware or IDPROM "Nelson, Shannon" <shannon.nelson@intel.com> - 2015-10-30 23:10 +0100
Re: [PATCH v3 net] i40e: Look up MAC address in Open Firmware or IDPROM Sowmini Varadhan <sowmini.varadhan@oracle.com> - 2015-10-31 00:20 +0100
Re: [PATCH v3 net] i40e: Look up MAC address in Open Firmware or IDPROM Sowmini Varadhan <sowmini.varadhan@oracle.com> - 2015-11-01 17:30 +0100
RE: [PATCH v3 net] i40e: Look up MAC address in Open Firmware or IDPROM "Nelson, Shannon" <shannon.nelson@intel.com> - 2015-11-01 22:10 +0100
csiph-web