[BUG] IB/hfi1: might sleep under spinlock in hfi1_ioctl()

From	Alexey Khoroshilov <khoroshilov@ispras.ru>
Newsgroups	linux.kernel
Subject	[BUG] IB/hfi1: might sleep under spinlock in hfi1_ioctl()
Date	2015-10-30 22:40 +0100
Message-ID	<qppyW-2yK-9@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello,

hfi1_ioctl() contains many calls to might sleep functions with
dd->hfi1_snoop.snoop_lock spinlock held (for example, access_ok,
copy_from_user, kzalloc(GFP_KERNEL), etc.).

Should dd->hfi1_snoop.snoop_lock be acquired just before updating state?

Found by Linux Driver Verification project (linuxtesting.org).

--
Alexey Khoroshilov
Linux Verification Center, ISPRAS
web: http://linuxtesting.org

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[BUG] IB/hfi1: might sleep under spinlock in hfi1_ioctl() Alexey Khoroshilov <khoroshilov@ispras.ru> - 2015-10-30 22:40 +0100
  Re: [BUG] IB/hfi1: might sleep under spinlock in hfi1_ioctl() "ira.weiny" <ira.weiny@intel.com> - 2015-10-31 01:00 +0100
    Re: [BUG] IB/hfi1: might sleep under spinlock in hfi1_ioctl() "ira.weiny" <ira.weiny@intel.com> - 2015-11-11 07:00 +0100

csiph-web