Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1259786

Re: [PATCH v4.3-rc7] be2iscsi : Fix bogus WARN_ON length check

Show all headers | View raw

Hi Tim,
tim.gardner@canonical.com writes:

> From: Tim Gardner <tim.gardner@canonical.com>
>
> drivers/scsi/be2iscsi/be_main.c: In function 'be_sgl_create_contiguous':
> drivers/scsi/be2iscsi/be_main.c:3187:18: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]
>   WARN_ON(!length > 0);
>
> gcc version 5.2.1

This patch (or similar) was already posted on Oct 1 by Joel Stanley.
See http://comments.gmane.org/gmane.linux.scsi/105462

Thanks,
        Johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4.3-rc7] be2iscsi : Fix bogus WARN_ON length check tim.gardner@canonical.com - 2015-10-30 19:30 +0100
  Re: [PATCH v4.3-rc7] be2iscsi : Fix bogus WARN_ON length check Manoj Kumar <manoj@linux.vnet.ibm.com> - 2015-10-30 20:30 +0100
  Re: [PATCH v4.3-rc7] be2iscsi : Fix bogus WARN_ON length check Johannes Thumshirn <jthumshirn@suse.de> - 2015-10-30 22:00 +0100
    Re: [PATCH v4.3-rc7] be2iscsi : Fix bogus WARN_ON length check Tim Gardner <tim.gardner@canonical.com> - 2015-11-01 17:00 +0100
  Re: [PATCH v4.3-rc7] be2iscsi : Fix bogus WARN_ON length check "Martin K. Petersen" <martin.petersen@oracle.com> - 2015-11-12 02:30 +0100

csiph-web