Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1259690

[PATCH v4.3-rc7] be2iscsi : Fix bogus WARN_ON length check

Show all headers | View raw

From: Tim Gardner <tim.gardner@canonical.com>

drivers/scsi/be2iscsi/be_main.c: In function 'be_sgl_create_contiguous':
drivers/scsi/be2iscsi/be_main.c:3187:18: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]
  WARN_ON(!length > 0);

gcc version 5.2.1

Cc: Jayamohan Kallickal <jayamohan.kallickal@avagotech.com>
Cc: Minh Tran <minh.tran@avagotech.com>
Cc: John Soni Jose <sony.john-n@avagotech.com>
Cc: "James E.J. Bottomley" <JBottomley@odin.com>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
---
 drivers/scsi/be2iscsi/be_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c
index 7a6dbfb..5cdcd29 100644
--- a/drivers/scsi/be2iscsi/be_main.c
+++ b/drivers/scsi/be2iscsi/be_main.c
@@ -3184,7 +3184,7 @@ be_sgl_create_contiguous(void *virtual_address,
 {
 	WARN_ON(!virtual_address);
 	WARN_ON(!physical_address);
-	WARN_ON(!length > 0);
+	WARN_ON(!length);
 	WARN_ON(!sgl);
 
 	sgl->va = virtual_address;
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v4.3-rc7] be2iscsi : Fix bogus WARN_ON length check tim.gardner@canonical.com - 2015-10-30 19:30 +0100
  Re: [PATCH v4.3-rc7] be2iscsi : Fix bogus WARN_ON length check Manoj Kumar <manoj@linux.vnet.ibm.com> - 2015-10-30 20:30 +0100
  Re: [PATCH v4.3-rc7] be2iscsi : Fix bogus WARN_ON length check Johannes Thumshirn <jthumshirn@suse.de> - 2015-10-30 22:00 +0100
    Re: [PATCH v4.3-rc7] be2iscsi : Fix bogus WARN_ON length check Tim Gardner <tim.gardner@canonical.com> - 2015-11-01 17:00 +0100
  Re: [PATCH v4.3-rc7] be2iscsi : Fix bogus WARN_ON length check "Martin K. Petersen" <martin.petersen@oracle.com> - 2015-11-12 02:30 +0100

csiph-web