Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1259480

Re: [RESEND PATCH v3] scsi: stex: Remove use of struct timeval

Show all headers | View raw

On Friday 30 October 2015 12:58:33 Hannes Reinecke wrote:
> > @@ -1076,7 +1069,7 @@ static int stex_ss_handshake(struct st_hba *hba)
> >       h->req_cnt = cpu_to_le16(hba->rq_count+1);
> >       h->status_sz = cpu_to_le16(sizeof(struct status_msg));
> >       h->status_cnt = cpu_to_le16(hba->sts_count+1);
> > -     stex_gettime(&h->hosttime);
> > +     h->hosttime = cpu_to_le64(ktime_get_real_seconds());
> >       h->partner_type = HMU_PARTNER_TYPE;
> >       h->extra_offset = h->extra_size = 0;
> >       scratch_size = (hba->sts_count+1)*sizeof(u32);
> > 
> Just remove 'hosttime' altogether. It serves no purpose whatsoever.
> 
> 

Are you sure? It is defined in a struct that is shared with the HBA
as part of hba->dma_mem, so unless you have access to the firmware,
it's hard to guess what it might be used for inside of the firmware.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RESEND PATCH v3] scsi: stex: Remove use of struct timeval Tina Ruchandani <ruchandani.tina@gmail.com> - 2015-10-30 09:40 +0100
  Re: [RESEND PATCH v3] scsi: stex: Remove use of struct timeval Johannes Thumshirn <jthumshirn@suse.de> - 2015-10-30 10:00 +0100
    Re: [RESEND PATCH v3] scsi: stex: Remove use of struct timeval Tina Ruchandani <ruchandani.tina@gmail.com> - 2015-10-30 10:00 +0100
      Re: [Y2038] [RESEND PATCH v3] scsi: stex: Remove use of struct timeval Arnd Bergmann <arnd@arndb.de> - 2015-10-31 00:40 +0100
  Re: [RESEND PATCH v3] scsi: stex: Remove use of struct timeval Hannes Reinecke <hare@suse.de> - 2015-10-30 13:00 +0100
    Re: [RESEND PATCH v3] scsi: stex: Remove use of struct timeval Arnd Bergmann <arnd@arndb.de> - 2015-10-30 13:50 +0100

csiph-web